Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates text description for Event sinks #11214

Merged
merged 1 commit into from
Mar 30, 2022
Merged

updates text description for Event sinks #11214

merged 1 commit into from
Mar 30, 2022

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Mar 22, 2022 •
edited
Loading

Fixes:
https://issues.redhat.com/browse/ODC-6523

Solution Description:

updates text description for Event sinks based on the provided text

Screen shots / Gifs for design review:

  • Event sink added in add flow

image

  • Event sink support in Catalog

image

  • Developer catalog popover on type

image

  • Create flow event sink with dynamic form/YAML view

image

  • Topology: Event sink side panel

image

  • Event Source: creation form

image

  • Topology: Event source side panel

image

Test setup:

  • Install Serverless operator and create CR for knativeServing/knativeEventing
  • Install Camel K operator
  • Create a Channel
  • Create Event sink from Add flow

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added component/knative Related to knative-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Mar 22, 2022
@invincibleJai
Copy link
Member Author

/cc @sahil143

@openshift-ci openshift-ci bot requested a review from sahil143 March 22, 2022 10:36
@sahil143
Copy link
Contributor

/cc @serenamarie125 @nainaz

Please take a look at the updated text.

@nainaz
Copy link

nainaz commented Mar 29, 2022

Can we add Event Source above Event Sink or these are alphabetized?
Other than that it looks good.
Thank you !

serenamarie125
serenamarie125 suggested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on request from Naina, please update the order of items in the Eventing card in the Add page:
(1) Event Source (2) Broker (3) Channel (4) Event Sink

frontend/packages/knative-plugin/locales/en/knative-plugin.json Outdated
"Required": "Required",
"No model registered for {{referenceForKnEventSink}}": "No model registered for {{referenceForKnEventSink}}",
"Event sink cannot be created": "Event sink cannot be created",
"Event sink is not found on this Cluster.": "Event sink is not found on this Cluster.",
"You do not have create access for Event sink in this project.": "You do not have create access for Event sink in this project.",
"Create an Event sink to register interest in a class of events from a particular system. Configure using the YAML and form views.": "Create an Event sink to register interest in a class of events from a particular system. Configure using the YAML and form views.",
"Create an Event sink to receive incoming events from a particular source. Configure using the YAML and form views.": "Create an Event sink to receive incoming events from a particular source. Configure using the YAML and form views.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be "Configure using YAML or form views."

@invincibleJai
Copy link
Member Author

Configure using the YAML and form views

Have updated this as per suggestion

image

serenamarie125
serenamarie125 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick updates!

@nainaz
Copy link

nainaz commented Mar 29, 2022

Looks good.
Thank you !!
good catch @serenamarie125 :)

@invincibleJai
Copy link
Member Author

/label docs-approved
/label px-approved

propagating above labels based on ACKs on epic

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Mar 30, 2022
sahil143
sahil143 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 30, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, sahil143, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

@invincibleJai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5490a4c into openshift:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil143 sahil143 sahil143 approved these changes

@serenamarie125 serenamarie125 serenamarie125 approved these changes

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@sahil143 sahil143

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@invincibleJai @sahil143 @nainaz @serenamarie125 @openshift-merge-robot