Bug 2076553: fix rolebinding in DevConsole dropping all subjects when updating

[debsmita1]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2076553
https://bugzilla.redhat.com/show_bug.cgi?id=2067064

Solution description:

• saving the whole subject instead of the subject name
• handling the roles with multiple subjects properly
• added tests

Test coverage:

/kind bug

[openshift-ci]

@debsmita1: This pull request references Bugzilla bug 2076553, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2076553: fix rolebinding in DevConsole dropping all subjects when updating

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[debsmita1]

/assign @jerolimov

[jerolimov]

/retest

[jerolimov]

Thanks for all these new tests! Need to take a deeper look tomorrow, here a small suggestion:

[jerolimov]

The caller should not know that sendRoleBindingRequest implementation and that it changes the parameter internally. This should be an implementation detail.

When it's easier to mutate the roleBinding parameter instead of using a spread operator in sendRoleBindingRequest you clone it inside instead, or?

[jerolimov]

@debsmita1, for me it doesn't fix the bug https://bugzilla.redhat.com/show_bug.cgi?id=2076553

I imported this YAML:

apiVersion: user.openshift.io/v1
kind: Group
metadata:
  name: a-group
users:
  - user1
  - user2
---
kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  generateName: a-group-binding
subjects:
  - kind: Group
    apiGroup: rbac.authorization.k8s.io
    name: a-group
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: view

Change the role from the group "a-group" from View to Edit

Search for the newly created RoleBinding "a-group-edit....":

kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: a-group-edit-185ab3d55b1625a8
subjects:
  - kind: User                                                # <-- Should be Group
    apiGroup: rbac.authorization.k8s.io
    name: a-group
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: edit

[jerolimov]

Tested both bugs and works fine 👍

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@debsmita1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@debsmita1: All pull requests linked via external trackers have merged:

• openshift/console#11292

Bugzilla bug 2076553 has been moved to the MODIFIED state.

In response to this:

Bug 2076553: fix rolebinding in DevConsole dropping all subjects when updating

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[debsmita1]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@debsmita1: #11292 failed to apply on top of branch "release-4.10":

Applying: fix rolebinding in DevConsole dropping all subjects when updating
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/project-access/ProjectAccess.tsx
M	frontend/packages/dev-console/src/components/project-access/ProjectAccessForm.tsx
M	frontend/packages/dev-console/src/components/project-access/project-access-form-validation-utils.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/components/project-access/project-access-form-validation-utils.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/project-access/project-access-form-validation-utils.ts
Auto-merging frontend/packages/dev-console/src/components/project-access/ProjectAccessForm.tsx
Auto-merging frontend/packages/dev-console/src/components/project-access/ProjectAccess.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix rolebinding in DevConsole dropping all subjects when updating
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.