[release-4.7] Bug 2073602: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls

[jerolimov]

Manual cherry-pick of 4.8 cherry-pick #11271.

There were just some issues with the imports.

Here is a recording of the import flows still works fine:

Peek.2022-04-11.09-24.mp4

Here is a recording comparing a production build 4.7 (left) against this PR (right), against a CRC:

Topology graph:

Peek.2022-04-11.09-32.mp4

Topology list:

Peek.2022-04-11.09-36.mp4

On a cluster, the difference is smaller... I will attach a cluster bot video as a comment.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2073602, which is invalid:

• expected dependent Bugzilla bug 2066365 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 2073602: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2073602, which is invalid:

• expected dependent Bugzilla bug 2066365 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 2073602: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/label backport-risk-assessed
/cc @rottencandy @invincibleJai
/assign @christianvogt

[jerolimov]

On a 4.7 cluster bot instance with 100 Deployments:

4.7.mov

timecodes:
0:02 click on topology
0:18 the loading indicator disappears (after 16s)
0:42 first time the deployments are visible (without icons) (after 40s overall)
1:00 graph is movable, layout buttons don't work yet
1:28 fit to screen works the first time

[jerolimov]

On a cluster bot instance with this PR:

pr.mov

timecodes:
0:02 click on topology / the right namespace
0:05 the loading indicator disappears (after 3s)
0:07-0:08 first time the deployments are visible (without icons) (after 5-6s overall)
0:08 graph is movable, layout buttons don't work yet
0:42 fit to screen works the first time

/cc @jrichter1

[jerolimov]

/bugzilla refresh

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 2073602, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2066365 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2066365 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
• bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rottencandy]

Tested on cluster.
GIt page does not crash, and topology does not lag for large number of deployments.
/lgtm

1.mp4

[jrichter1]

/label cherry-pick-approved

[christianvogt]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jerolimov, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#11309

Bugzilla bug 2073602 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 2073602: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.