-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.7] Bug 2073602: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls #11309
[release-4.7] Bug 2073602: (Topology) Performance improvement by reducing rerenderings and deep-copy toJSON() calls #11309
Conversation
…copy toJSON() calls
by extracting k8s-ref methods similar to 4.9 and 'downgrade' newly added unit tests from @testing-library/react to react-dom/test-utils
@jerolimov: This pull request references Bugzilla bug 2073602, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jerolimov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jerolimov: This pull request references Bugzilla bug 2073602, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label backport-risk-assessed |
On a 4.7 cluster bot instance with 100 Deployments: 4.7.movtimecodes: |
On a cluster bot instance with this PR: pr.movtimecodes: /cc @jrichter1 |
/bugzilla refresh |
@jerolimov: This pull request references Bugzilla bug 2073602, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on cluster.
GIt page does not crash, and topology does not lag for large number of deployments.
/lgtm
1.mp4
/label cherry-pick-approved |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jerolimov, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jerolimov: All pull requests linked via external trackers have merged: Bugzilla bug 2073602 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherry-pick of 4.8 cherry-pick #11271.
There were just some issues with the imports.
Here is a recording of the import flows still works fine:
Peek.2022-04-11.09-24.mp4
Here is a recording comparing a production build 4.7 (left) against this PR (right), against a CRC:
Topology graph:
Peek.2022-04-11.09-32.mp4
Topology list:
Peek.2022-04-11.09-36.mp4
On a cluster, the difference is smaller... I will attach a cluster bot video as a comment.