-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.10] Bug 2077142: Fix Web Terminal availability check to verify operator is installed #11374
Conversation
The fix for https://bugzilla.redhat.com/show_bug.cgi?id=2006329 introduced a regression by changing the backend check for a Web Terminal Operator subscription to work via a list instead of get operation. For a get, if the object does not exist, the API returns a not found error, whereas for a list, the response is an empty list. The backend /api/terminal/available/ endpoint would still check for the "not found" error and assume its absence meant the terminal was installed, despite the list having zero items. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2065804 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@openshift-cherrypick-robot: Bugzilla bug 2065804 has been cloned as Bugzilla bug 2077142. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2077142, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/bugzilla refresh |
@amisevsk: This pull request references Bugzilla bug 2077142, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
/remove-lifecycle rotten |
/bugzilla refresh |
@invincibleJai: This pull request references Bugzilla bug 2077142, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm /assign @jhadvig |
/label backport-risk-assessed |
/label cherry-pick-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, jhadvig, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 2077142 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #11202
/assign amisevsk