Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2077142: Fix Web Terminal availability check to verify operator is installed #11374

Merged
merged 1 commit into from Aug 30, 2022
Merged

[release-4.10] Bug 2077142: Fix Web Terminal availability check to verify operator is installed #11374

merged 1 commit into from Aug 30, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #11202

/assign amisevsk

@amisevsk
Bug 2065804: Fix Web Terminal availability check to verify installation
d76fa14 
The fix for https://bugzilla.redhat.com/show_bug.cgi?id=2006329
introduced a regression by changing the backend check for a Web Terminal
Operator subscription to work via a list instead of get operation. For a
get, if the object does not exist, the API returns a not found error,
whereas for a list, the response is an empty list.

The backend /api/terminal/available/ endpoint would still check for the
"not found" error and assume its absence meant the terminal was
installed, despite the list having zero items.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2065804

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 20, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2022

@openshift-cherrypick-robot: Bugzilla bug 2065804 has been cloned as Bugzilla bug 2077142. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2077142: Fix Web Terminal availability check to verify operator is installed

In response to this:

[release-4.10] Bug 2065804: Fix Web Terminal availability check to verify operator is installed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] Bug 2065804: Fix Web Terminal availability check to verify operator is installed [release-4.10] Bug 2077142: Fix Web Terminal availability check to verify operator is installed Apr 20, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2077142, which is invalid:

  • expected dependent Bugzilla bug 2065804 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.10] Bug 2077142: Fix Web Terminal availability check to verify operator is installed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from florkbr and jhadvig April 20, 2022 18:09
@openshift-ci openshift-ci bot added the component/backend Related to backend label Apr 20, 2022
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2022
@amisevsk
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

@amisevsk: This pull request references Bugzilla bug 2077142, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2065804 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2065804 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sanketpathak July 21, 2022 20:21
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 21, 2022
@amisevsk
Copy link
Contributor

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 22, 2022
@invincibleJai invincibleJai mentioned this pull request Aug 25, 2022
Merged
@invincibleJai
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022

@invincibleJai: This pull request references Bugzilla bug 2077142, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2065804 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2065804 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@invincibleJai
Copy link
Member

/cc @abhinandan13jan @sanketpathak @jhadvig

@invincibleJai
Copy link
Member

Verified on cluster bot and seems to work as expected i.e Web Terminal button is not present in UI until Web Terminal Operator is installed even if dev workspaces operator was preinstalled.

WTO-DW2

@invincibleJai
Copy link
Member

/lgtm

/assign @jhadvig

@invincibleJai
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 25, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@invincibleJai
Copy link
Member

/cc @sanketpathak @hemantsaini-7

@hemantsaini-7
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 29, 2022
jhadvig
jhadvig approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jhadvig, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 853e75e and 8 for PR HEAD d76fa14 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 853e75e and 7 for PR HEAD d76fa14 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 42ff3b8 into openshift:release-4.10 Aug 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2077142 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2077142: Fix Web Terminal availability check to verify operator is installed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@florkbr florkbr Awaiting requested review from florkbr

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@hemantsaini-7 hemantsaini-7 Awaiting requested review from hemantsaini-7

Assignees

@jhadvig jhadvig

@invincibleJai invincibleJai

@amisevsk amisevsk

@florkbr florkbr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/backend Related to backend lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-bot @amisevsk @invincibleJai @hemantsaini-7 @openshift-ci-robot @jhadvig @florkbr @openshift-merge-robot