Add cluster channel modal #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
spadgett
reviewed
Jan 29, 2019
frontend/public/components/cluster-settings/cluster-settings.tsx
Outdated
Show resolved
Hide resolved
frontend/public/components/cluster-settings/cluster-settings.tsx
Outdated
Show resolved
Hide resolved
|
We probably want a blurb at the top of the dialog describing channels with guidance on what to select. |
rhamilto
force-pushed
the
cluster-channel-modal
branch
2 times, most recently
from
8ff8c8a
to
bc9cf96
Compare
openshift-ci-robot
added
the
needs-rebase
rhamilto
force-pushed
the
cluster-channel-modal
branch
from
bc9cf96
to
a4bff8e
Compare
openshift-ci-robot
added
needs-rebase
rhamilto
force-pushed
the
cluster-channel-modal
branch
from
a4bff8e
to
32d0787
Compare
openshift-ci-robot
removed
the
needs-rebase
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Looks good. We just need the exception to be approved to remove the hold. /assign @TheRealJon @benjaminapetersen Jon, can you take over this PR since Robb is out? It should just be getting it through CI and removing the hold when we can. @benjaminapetersen is on the exception mailing list thread. |
|
/test all |
|
@spadgett Will do |
|
/hold remove We have approval on this. |
|
/unhold |
|
i forget what the comment is, gimme a min 😄 |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
ha, got it. |
|
/retest |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.coreos.com/browse/CONSOLE-1062