-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster channel modal #1146
Add cluster channel modal #1146
Conversation
/hold |
frontend/public/components/cluster-settings/cluster-settings.tsx
Outdated
Show resolved
Hide resolved
frontend/public/components/cluster-settings/cluster-settings.tsx
Outdated
Show resolved
Hide resolved
We probably want a blurb at the top of the dialog describing channels with guidance on what to select. |
8ff8c8a
to
bc9cf96
Compare
bc9cf96
to
a4bff8e
Compare
a4bff8e
to
32d0787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks good. We just need the exception to be approved to remove the hold. /assign @TheRealJon @benjaminapetersen Jon, can you take over this PR since Robb is out? It should just be getting it through CI and removing the hold when we can. @benjaminapetersen is on the exception mailing list thread. |
/test all |
@spadgett Will do |
/hold remove We have approval on this. |
/unhold |
i forget what the comment is, gimme a min 😄 |
/hold cancel |
ha, got it. |
/retest |
👍 |
https://jira.coreos.com/browse/CONSOLE-1062