Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where catalog overlay is still open when canceling create #1153

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

rhamilto
Copy link
Member

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1670698

Calling closeOverlay here preserves the other query string parameters, thus maintaining any filters the user may have set on the catalog.

lcaipxguub

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2019
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 378bdaf into openshift:master Jan 30, 2019
@rhamilto rhamilto deleted the bz1670698 branch January 30, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants