-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update machine API group and version #1161
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
spadgett:machine-api-group
Feb 8, 2019
Merged
Update machine API group and version #1161
openshift-merge-robot
merged 1 commit into
openshift:master
from
spadgett:machine-api-group
Feb 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Feb 1, 2019
spadgett
force-pushed
the
machine-api-group
branch
from
February 1, 2019 18:34
3e37cd6
to
2b4377b
Compare
looks good to me |
spadgett
force-pushed
the
machine-api-group
branch
from
February 7, 2019 16:49
2b4377b
to
a2344bb
Compare
spadgett
changed the title
[WIP] Update machine API group and version
Update machine API group and version
Feb 7, 2019
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Feb 7, 2019
/assign @TheRealJon |
The installer changes have merged. This should be ready. |
TheRealJon
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test frontend |
/retest |
2 similar comments
/retest |
/retest |
flake https://jira.coreos.com/browse/CONSOLE-1266 /retest |
/retest |
1 similar comment
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster.k8s.io/v1alpha1 -> machine.openshift.io/v1beta1
See openshift/installer#1175
cc @jwforres @derekwaynecarr