Bug 2093601: allow project access page to update the settings twice

[debsmita1]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2093601

Root analysis:
The submit button was disabled because when the form is updated after being saved the validation schema returns namespace required error

Solution description:
Removed namespace from the validation schema

GIF:

/kind bug

[openshift-ci]

@debsmita1: This pull request references Bugzilla bug 2093601, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Bug 2093601: allow project access page to update the settings twice

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[debsmita1]

/assign @jerolimov

[debsmita1]

/retest

[invincibleJai]

do we need this in initial values then?

[debsmita1]

removed it

[debsmita1]

/retest

[jerolimov]

/retest

[jerolimov]

Two more ideas were unrelated to this bug!

As discussed in slack:

1. Instead of modifying a global const roleBinding: RoleBinding in project-access-form-utils-types.ts I would make the code cleaner to pass the namespace to sendRoleBindingRequest
2. Replace getActiveNamespace() with just namespace (from the props = from the URL)

[jerolimov]

nit :)

[jerolimov]

This might work (as before) because the network call serializes the body (roleBinding) in sendK8sRequest

But I would recommend to not modifying the roleBinding in every _.forEach(roles,... loops and passing the same instance (===) multiple times to another API call.

Can you move this const roleBinding: Rolebinding... into the loop? And then we might also can set the metadata.name and maybe other fields when constructing it instead of assign/modify it.

Suggested change

	const roleBinding: RoleBinding = {
	apiVersion: 'rbac.authorization.k8s.io/v1',
	kind: 'RoleBinding',
	metadata: {
	name: '',
	namespace,
	},
	roleRef: {
	apiGroup: 'rbac.authorization.k8s.io',
	kind: 'ClusterRole',
	name: '',
	},
	subjects: [],
	};
	const roleBinding: RoleBinding = {
	apiVersion: 'rbac.authorization.k8s.io/v1',
	kind: 'RoleBinding',
	metadata: {
	name: roleBindingName,
	namespace,
	},
	roleRef: {
	apiGroup: 'rbac.authorization.k8s.io',
	kind: 'ClusterRole',
	name: user.role,
	},
	subjects,
	};

[jerolimov]

Thanks, tested it and it works fine 👍

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@debsmita1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@debsmita1: All pull requests linked via external trackers have merged:

• openshift/console#11713

Bugzilla bug 2093601 has been moved to the MODIFIED state.

In response to this:

Bug 2093601: allow project access page to update the settings twice

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.