add parameters tab on PipelineRun details page #11767

vikram-raj · 2022-06-28T15:28:40Z

Story: https://issues.redhat.com/browse/ODC-6709

Description:

add the parameters tab on the PipelineRun details page

Screenshots:

Tests e2e:

vikram-raj · 2022-06-28T15:29:08Z

/cc @jerolimov @karthikjeeyar

frontend/packages/pipelines-plugin/src/components/pipelineruns/PipelineRunParameters.tsx

jerolimov · 2022-06-28T23:16:34Z

frontend/packages/pipelines-plugin/src/components/pipelineruns/PipelineRunParametersForm.tsx

+    <Form>
+      <div className="co-m-pane__body">
+        <PipelineRunParameters fieldName="parameters" />
+      </div>
+      <FormFooter
+        handleCancel={handleCancel}
+        cancelLabel={t('pipelines-plugin~Cancel')}
+        hideSubmit
+        sticky
+      />
+    </Form>


In PipelineRunParameters you define all fields as read-only. Why do we need a form and cancel button on this tab?

My initial thought was the same. Removed the Form and cancel button.

@vikram-raj But there is still a PipelineRunParametersForm.tsx and formik, this is required to fill the form fields? Then its fine for me.

Yes, I used Formik to fill the form fields.

vikram-raj · 2022-06-30T11:10:29Z

/retest

jerolimov · 2022-07-01T13:18:12Z

@vikram-raj Nice! Thanks for the update. Can you also add a cypress e2e test for this? 😏

vikram-raj · 2022-07-04T17:39:48Z

@vikram-raj Nice! Thanks for the update. Can you also add a cypress e2e test for this? 😏

@jerolimov added cypress e2e tests.

.../packages/pipelines-plugin/integration-tests/support/pages/pipelines/pipelineBuilder-page.ts

frontend/packages/pipelines-plugin/integration-tests/features/pipelines/pipelines-runs.feature

invincibleJai · 2022-07-05T12:24:07Z

@vikram-raj alignment looks bit off too

serenamarie125 · 2022-07-05T12:24:47Z

@beaumorley can you take a look into the disabled text inputs with PatternFly? Thanks!

frontend/packages/pipelines-plugin/src/components/pipelineruns/PipelineRunParametersForm.tsx

frontend/packages/pipelines-plugin/src/components/pipelineruns/PipelineRunParameters.tsx

beaumorley · 2022-07-06T20:22:09Z

It looks like the individual disabled fields have a 1 pt stroke at the bottom? If you look at the PF guideline, it is just a plain grey box. https://www.patternfly.org/v4/components/text-input Can we remove the stroke?

Also, it you take a look at a disabled on the admin side there is no stroke. Example:

FYI @serenamarie125
Thank you!

vikram-raj · 2022-07-07T11:41:50Z

@beaumorley Fixed disable style.

vikram-raj · 2022-07-07T18:41:21Z

@vikram-raj alignment looks bit off too

@invincibleJai Fixed the alignment issue in this PR #11799

invincibleJai · 2022-07-14T07:37:02Z

/retest

openshift-ci · 2022-07-14T10:25:33Z

@invincibleJai: GitHub didn't allow me to request PR reviews from the following users: check, and, add, for, once, done, do, e2d, label.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @sanketpathak do check e2d and add label for QE-verification once done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai · 2022-07-15T07:09:42Z

/cc @sanketpathak

invincibleJai · 2022-07-15T07:28:28Z

/lgtm

jerolimov · 2022-07-15T09:12:31Z

/retest

hemantsaini-7 · 2022-07-18T09:05:43Z

frontend/packages/pipelines-plugin/integration-tests/support/page-objects/pipelines-po.ts

@@ -231,6 +232,9 @@ export const pipelineRunDetailsPO = {
    },
    status: '.odc-taskrun-details__status',
  },
+  parameters: {
+    form: '[data-test="pipelineRun-parameters"]',


form: '[data-test="pipeline-parameters"]' instead of form: '[data-test="pipelineRun-parameters"]'

Forgot to update the data-test after the component refactoring. Updated it now. PTAL again.

…eRun parameters

hemantsaini-7 · 2022-07-18T14:02:44Z

/lgtm

openshift-ci · 2022-07-18T14:06:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hemantsaini-7, invincibleJai, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/pipelines-plugin/OWNERS~~ [invincibleJai,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

beaumorley · 2022-07-18T15:10:02Z

@vikram-raj thanks for fixing the disabled pattern. LGTM.

vikram-raj

Propagating docs and px acks from the Epic ODC-4793
/label docs-approved
/label px-approved

hemantsaini-7 · 2022-07-21T07:04:19Z

/label qe-approved

vikram-raj · 2022-07-21T07:21:32Z

/retest

openshift-ci · 2022-07-21T11:04:31Z

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot requested review from jerolimov, karthikjeeyar, rohitkrai03 and spadgett June 28, 2022 15:29

openshift-ci bot added component/pipelines Related to pipelines-plugin component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jun 28, 2022

jerolimov suggested changes Jun 28, 2022

View reviewed changes

vikram-raj force-pushed the odc-6709 branch from f0703a5 to 60bd6ad Compare June 30, 2022 07:52

vikram-raj requested a review from jerolimov June 30, 2022 07:57

vikram-raj force-pushed the odc-6709 branch from 60bd6ad to 7789414 Compare June 30, 2022 14:27

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022

vikram-raj force-pushed the odc-6709 branch from 7789414 to 3e25b48 Compare July 1, 2022 04:34

invincibleJai reviewed Jul 5, 2022

View reviewed changes

.../packages/pipelines-plugin/integration-tests/support/pages/pipelines/pipelineBuilder-page.ts Show resolved Hide resolved

frontend/packages/pipelines-plugin/integration-tests/features/pipelines/pipelines-runs.feature Outdated Show resolved Hide resolved

karthikjeeyar reviewed Jul 5, 2022

View reviewed changes

frontend/packages/pipelines-plugin/src/components/pipelineruns/PipelineRunParametersForm.tsx Outdated Show resolved Hide resolved

karthikjeeyar reviewed Jul 6, 2022

View reviewed changes

frontend/packages/pipelines-plugin/src/components/pipelineruns/PipelineRunParameters.tsx Outdated Show resolved Hide resolved

vikram-raj force-pushed the odc-6709 branch from 122470c to 0d57bf9 Compare July 6, 2022 12:20

openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2022

vikram-raj force-pushed the odc-6709 branch from 416af3c to 874523c Compare July 7, 2022 14:26

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2022

vikram-raj added 3 commits July 14, 2022 18:47

add parameters tab on PipelineRun details page

f32a797

add cypress e2e tests for pipelineRun parameters tab

404cb82

fix disbale field style for parameters field

716ad44

vikram-raj force-pushed the odc-6709 branch from 874523c to 91fba83 Compare July 14, 2022 15:57

vikram-raj requested a review from karthikjeeyar July 14, 2022 15:59

openshift-ci bot assigned invincibleJai Jul 15, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2022

hemantsaini-7 reviewed Jul 18, 2022

View reviewed changes

refactor PipelineParameters component to use for Pipeline and Pipelin…

beaa111

…eRun parameters

vikram-raj force-pushed the odc-6709 branch from 91fba83 to beaa111 Compare July 18, 2022 10:43

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022

vikram-raj requested a review from hemantsaini-7 July 18, 2022 10:45

openshift-ci bot assigned hemantsaini-7 Jul 18, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022

vikram-raj commented Jul 21, 2022

View reviewed changes

openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 21, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 21, 2022

openshift-merge-robot merged commit eee5daa into openshift:master Jul 21, 2022

vikram-raj deleted the odc-6709 branch July 22, 2022 07:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add parameters tab on PipelineRun details page #11767

add parameters tab on PipelineRun details page #11767

vikram-raj commented Jun 28, 2022 •

edited

Loading

vikram-raj commented Jun 28, 2022

jerolimov Jun 28, 2022

vikram-raj Jun 30, 2022

jerolimov Jul 14, 2022 •

edited

Loading

vikram-raj Jul 14, 2022

vikram-raj commented Jun 30, 2022

jerolimov commented Jul 1, 2022

vikram-raj commented Jul 4, 2022

invincibleJai commented Jul 5, 2022

serenamarie125 commented Jul 5, 2022

beaumorley commented Jul 6, 2022

vikram-raj commented Jul 7, 2022 •

edited

Loading

vikram-raj commented Jul 7, 2022

invincibleJai commented Jul 14, 2022

openshift-ci bot commented Jul 14, 2022

invincibleJai commented Jul 15, 2022

invincibleJai commented Jul 15, 2022

jerolimov commented Jul 15, 2022

hemantsaini-7 Jul 18, 2022 •

edited

Loading

vikram-raj Jul 18, 2022

hemantsaini-7 commented Jul 18, 2022

openshift-ci bot commented Jul 18, 2022

beaumorley commented Jul 18, 2022

vikram-raj left a comment

hemantsaini-7 commented Jul 21, 2022

vikram-raj commented Jul 21, 2022

openshift-ci bot commented Jul 21, 2022

add parameters tab on PipelineRun details page #11767

add parameters tab on PipelineRun details page #11767

Conversation

vikram-raj commented Jun 28, 2022 • edited Loading

vikram-raj commented Jun 28, 2022

jerolimov Jun 28, 2022

Choose a reason for hiding this comment

vikram-raj Jun 30, 2022

Choose a reason for hiding this comment

jerolimov Jul 14, 2022 • edited Loading

Choose a reason for hiding this comment

vikram-raj Jul 14, 2022

Choose a reason for hiding this comment

vikram-raj commented Jun 30, 2022

jerolimov commented Jul 1, 2022

vikram-raj commented Jul 4, 2022

invincibleJai commented Jul 5, 2022

serenamarie125 commented Jul 5, 2022

beaumorley commented Jul 6, 2022

vikram-raj commented Jul 7, 2022 • edited Loading

vikram-raj commented Jul 7, 2022

invincibleJai commented Jul 14, 2022

openshift-ci bot commented Jul 14, 2022

invincibleJai commented Jul 15, 2022

invincibleJai commented Jul 15, 2022

jerolimov commented Jul 15, 2022

hemantsaini-7 Jul 18, 2022 • edited Loading

Choose a reason for hiding this comment

vikram-raj Jul 18, 2022

Choose a reason for hiding this comment

hemantsaini-7 commented Jul 18, 2022

openshift-ci bot commented Jul 18, 2022

beaumorley commented Jul 18, 2022

vikram-raj left a comment

Choose a reason for hiding this comment

hemantsaini-7 commented Jul 21, 2022

vikram-raj commented Jul 21, 2022

openshift-ci bot commented Jul 21, 2022

vikram-raj commented Jun 28, 2022 •

edited

Loading

jerolimov Jul 14, 2022 •

edited

Loading

vikram-raj commented Jul 7, 2022 •

edited

Loading

hemantsaini-7 Jul 18, 2022 •

edited

Loading