Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1677214 - Email field should be an optional on Create Image Pull Secret page #1186

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Bug 1677214 - Email field should be an optional on Create Image Pull Secret page #1186

merged 1 commit into from
Feb 25, 2019

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Feb 14, 2019

/assign @jcaianirh

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2019
@benjaminapetersen
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@jhadvig
Copy link
Member Author

jhadvig commented Feb 14, 2019

/test console-e2e

@benjaminapetersen
Copy link
Contributor

/retest

jcaianirh
jcaianirh approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jhadvig
Copy link
Member Author

jhadvig commented Feb 14, 2019

/test console-e2e

@benjaminapetersen
Copy link
Contributor

/retest

@benjaminapetersen
Copy link
Contributor

/retest

operator PR 143 merged, lets see if the TLS issue with the authentication operator goes away.

@spadgett
Copy link
Member

/retest

4 similar comments
@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

install failed

/retest

@spadgett
Copy link
Member

/retest

3 similar comments
@spadgett
Copy link
Member

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Feb 25, 2019

/retest

@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit f5ece42 into openshift:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaianirh jcaianirh jcaianirh approved these changes

Assignees

@benjaminapetersen benjaminapetersen

@jcaianirh jcaianirh

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jhadvig @benjaminapetersen @spadgett @jcaianirh @openshift-ci-robot @openshift-merge-robot