OCPBUGS-1677: Fix devfile registry assertion #12085
Conversation
openshift-ci-robot
added
jira/valid-bug
|
@jerolimov: This pull request references Jira Issue OCPBUGS-1677, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
component/backend
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -72,7 +72,7 @@ func TestGetRegistrySamples(t *testing.T) { | |||
| DisplayName: "Basic Python", | |||
| Description: "A simple Hello World application using Python", | |||
| Tags: []string{"Python"}, | |||
| Icon: "https://www.python.org/static/community_logos/python-logo-generic.svg", | |||
| Icon: "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/python.svg", | |||
There was a problem hiding this comment.
Should we consider relaxing some of these tests so they don't break when things change? For instance, checking if python exists, has some icon, etc, but not necessarily all of the exact values.
Let's merge this to unblock CI, but maybe as a follow up.
There was a problem hiding this comment.
OK I see this is already tracked by https://issues.redhat.com/browse/OCPBUGS-1678, thanks 👍
|
@jerolimov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jerolimov: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1677 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.11 |
|
@jerolimov: new pull request created: #12108 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/OCPBUGS-1677
Analysis / Root cause:
pkg/devfile/sample_test.go fails after devfile registry was updated (devfile/registry#126)
Solution Description:
Just updated the assertion.
https://issues.redhat.com/browse/OCPBUGS-1678 is about updating the code so that the test should use a mock response instead of the latest registry content OR check some specific attributes instead of comparing the full JSON response.