Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the python stack/sample icons #126

Merged
merged 1 commit into from Sep 22, 2022

Conversation

schultzp2020
Copy link
Contributor

@schultzp2020 schultzp2020 commented Sep 22, 2022

Signed-off-by: Paul Schultz pschultz@pobox.com

What does this PR do?:

Updates the python stack/sample icons

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020 schultzp2020 self-assigned this Sep 22, 2022
@schultzp2020 schultzp2020 changed the title Updated python stack/sample icons Updated the python stack/sample icons Sep 22, 2022
@schultzp2020
Copy link
Contributor Author

The tests will pass once #125 is deployed to product.

@schultzp2020
Copy link
Contributor Author

/retest

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Sep 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron, schultzp2020
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval by writing /assign @johnmcollier in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schultzp2020 schultzp2020 merged commit ed56c41 into devfile:main Sep 22, 2022
@schultzp2020 schultzp2020 deleted the update-python-images branch September 22, 2022 23:51
@michael-valdron michael-valdron mentioned this pull request Sep 23, 2022
4 tasks
kadel pushed a commit to kadel/registry that referenced this pull request Sep 28, 2022
Signed-off-by: Paul Schultz <pschultz@pobox.com>
kadel pushed a commit to kadel/registry that referenced this pull request Sep 29, 2022
Signed-off-by: Paul Schultz <pschultz@pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me
Projects
None yet
2 participants