Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1948666: Fix to show correct help texts for each git repo status error code #12237

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Bug 1948666: Fix to show correct help texts for each git repo status error code #12237

merged 2 commits into from
Dec 17, 2022

Conversation

divyanshiGupta
Copy link
Contributor

@divyanshiGupta divyanshiGupta commented Nov 4, 2022 •
edited
Loading

Fixes: https://issues.redhat.com/browse/OCPBUGSM-27634
Fixes: https://issues.redhat.com/browse/OCPBUGS-446

This PR adds more error codes to git-service to correctly identify the issue with the repo not being accessible. It also adds/updates the repo statuses and its corresponding help texts.

Invalid git-type selected:
Screenshot 2022-11-30 at 9 57 33 PM

Private repo:
Screenshot 2022-11-30 at 9 55 40 PM

Git-type not identified:
Screenshot 2022-11-30 at 9 54 12 PM

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/git-service Related to git-service approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Nov 4, 2022
@divyanshiGupta divyanshiGupta changed the title Fix to show correct help texts for each git repo status error code Bug 1948666: Fix to show correct help texts for each git repo status error code Nov 4, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2022

@divyanshiGupta: This pull request references Bugzilla bug 1948666, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1948666: Fix to show correct help texts for each git repo status error code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@invincibleJai
Copy link
Member

@divyanshiGupta do update PR description with screenshots/gif as needed and then will be good to get it reviewed by PM/UX as well

cc @jerolimov

@openshift-ci openshift-ci bot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022

@divyanshiGupta: This pull request references Bugzilla bug 1948666, which is invalid:

  • expected the bug to target the "4.13.0" release, but it targets "4.12.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1948666: Fix to show correct help texts for each git repo status error code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyanshiGupta
Copy link
Contributor Author

cc: @serenamarie125

@divyanshiGupta
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

@divyanshiGupta: This pull request references Bugzilla bug 1948666, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikram-raj
vikram-raj reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyanshiGupta Should we remove the Default Git type to other info alert when the user changes the Git type? wdyt?
Peek 2022-12-12 15-15

frontend/packages/dev-console/src/components/import/git/GitSection.tsx Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

@divyanshiGupta: This pull request references Bugzilla bug 1948666, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1948666: Fix to show correct help texts for each git repo status error code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyanshiGupta
Copy link
Contributor Author

@divyanshiGupta Should we remove the Default Git type to other info alert when the user changes the Git type? wdyt? Peek 2022-12-12 15-15 Peek 2022-12-12 15-15

@vikram-raj Yes we should remove the info alert. Please create a new ticket for this issue as it is not related to this.

@divyanshiGupta
Copy link
Contributor Author

/retest

@lokanandaprabhu
Copy link
Contributor

Tested in local.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divyanshiGupta
Copy link
Contributor Author

/retest

3 similar comments
@lokanandaprabhu
Copy link
Contributor

/retest

@divyanshiGupta
Copy link
Contributor Author

/retest

@divyanshiGupta
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 40413bf and 2 for PR HEAD edc5ec2 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d5d32d0 and 1 for PR HEAD edc5ec2 in total

@divyanshiGupta
Copy link
Contributor Author

/retest

2 similar comments
@divyanshiGupta
Copy link
Contributor Author

/retest

@divyanshiGupta
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d03979a and 0 for PR HEAD edc5ec2 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2022

@divyanshiGupta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 84e7314 into openshift:master Dec 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2022

@divyanshiGupta: All pull requests linked via external trackers have merged:

Bugzilla bug 1948666 has been moved to the MODIFIED state.

In response to this:

Bug 1948666: Fix to show correct help texts for each git repo status error code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyanshiGupta
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 21, 2022
Merged
@openshift-cherrypick-robot
Copy link

@divyanshiGupta: new pull request created: #12389

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

Assignees

@lokanandaprabhu lokanandaprabhu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console component/git-service Related to git-service kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@divyanshiGupta @invincibleJai @lokanandaprabhu @openshift-ci-robot @openshift-cherrypick-robot @vikram-raj @openshift-merge-robot