OCPBUGS-4026: Fix rerender loop/crash when bindable-kinds is found but has no status

[jerolimov]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-4026

Analysis / Root cause:
This statement creates always a new bindableServices array when the bindable-kinds resource is found, but has no status.

  const bindableServices: BindableServiceGVK[] = bindableKindsRes?.status ?? [];

Since this is used for the useCallback dependencies this catalog providers updates the catalog again and again.

Solution Description:
Changed the useCallback dependencies to the bindableKinds and loaded so that the callback is only updated if one of these both changed. Checked that the status array is defined (with isArray) in the callback function.

Screen shots / Gifs for design review:
Before:

before.mp4

After:

after.mp4

Unit test coverage report:
Unchanged

Test setup:

1. Install Service Binding Operator
2. Create or update the BindableKinds resource "bindable-kinds"

apiVersion: binding.operators.coreos.com/v1alpha1
kind: BindableKinds
metadata:
  name: bindable-kinds

3. Open the browser console log
4. Open the console UI and navigate to the add page

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-4026, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-4026

Analysis / Root cause:
This statement creates always a new bindableServices array when the bindable-kinds resource is found, but has no status.

 const bindableServices: BindableServiceGVK[] = bindableKindsRes?.status ?? [];

Since this is used for the useCallback dependencies this catalog providers updates the catalog again and again.

Solution Description:
Changed the useCallback dependencies to the bindableKinds and loaded so that the callback is only updated if one of these both changed. Checked that the status array is defined (with isArray) in the callback function.

Screen shots / Gifs for design review:
Before:

before.mp4

After:

after.mp4

Unit test coverage report:
Unchanged

Test setup:

1. Install Service Binding Operator
2. Create or update the BindableKinds resource "bindable-kinds"

apiVersion: binding.operators.coreos.com/v1alpha1
kind: BindableKinds
metadata:
 name: bindable-kinds

3. Open the browser console log
4. Open the console UI and navigate to the add page

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/kind bug
/uncc andrewballantyne rohitkrai03
/cc @divyanshiGupta @debsmita1

[jerolimov]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@jerolimov: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/lgtm

[vikram-raj]

Verified it locally. and it works as expected

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [invincibleJai,jerolimov,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a4ad164 and 2 for PR HEAD e34fe38 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 857f388 and 1 for PR HEAD e34fe38 in total

[openshift-ci-robot]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#12296

Jira Issue OCPBUGS-4026 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-4026

Analysis / Root cause:
This statement creates always a new bindableServices array when the bindable-kinds resource is found, but has no status.

 const bindableServices: BindableServiceGVK[] = bindableKindsRes?.status ?? [];

Since this is used for the useCallback dependencies this catalog providers updates the catalog again and again.

Solution Description:
Changed the useCallback dependencies to the bindableKinds and loaded so that the callback is only updated if one of these both changed. Checked that the status array is defined (with isArray) in the callback function.

Screen shots / Gifs for design review:
Before:

before.mp4

After:

after.mp4

Unit test coverage report:
Unchanged

Test setup:

1. Install Service Binding Operator
2. Create or update the BindableKinds resource "bindable-kinds"

apiVersion: binding.operators.coreos.com/v1alpha1
kind: BindableKinds
metadata:
 name: bindable-kinds

3. Open the browser console log
4. Open the console UI and navigate to the add page

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@jerolimov: new pull request created: #12304

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.