Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.11] OCPBUGS-6492: Add RBAC check on Create a Project link in all-namespaces pages #12514

Conversation

vikram-raj
Copy link
Member

Manual cherry-pick of #12489

/cc @jerolimov

@openshift-ci openshift-ci bot requested a review from jerolimov February 1, 2023 07:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2023

@vikram-raj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add RBAC check on Create a Project link in all-namespaces pages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/helm Related to helm-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Feb 1, 2023
@vikram-raj vikram-raj changed the title Add RBAC check on Create a Project link in all-namespaces pages [release-4.11] OCPBUGS-6492: Add RBAC check on Create a Project link in all-namespaces pages Feb 1, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 1, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-6492, which is invalid:

  • expected the bug to target the "4.11.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-6492 to depend on a bug targeting a version in 4.12.0, 4.12.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of #12489

/cc @jerolimov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2023

@vikram-raj: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-6492: Add RBAC check on Create a Project link in all-namespaces pages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-6492, which is invalid:

  • expected Jira Issue OCPBUGS-6492 to depend on a bug targeting a version in 4.12.0, 4.12.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-6492, which is invalid:

  • expected dependent Jira Issue OCPBUGS-6758 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on a cluster bot and it work as expected 👍

pr-12514-cluster-bot.mp4

/label backport-risk-assessed
/lgtm
/approve

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 4, 2023
@jerolimov
Copy link
Member

/cc @sanketpathak @hemantsaini-7

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hemantsaini-7
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 6, 2023
@vikram-raj
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 13, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-6492, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-6758 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-6758 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 13, 2023
@vikram-raj
Copy link
Member Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@vikram-raj: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit adb1684 into openshift:release-4.11 Feb 13, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6492 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of #12489

/cc @jerolimov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@vikram-raj: #12514 failed to apply on top of branch "release-4.10":

Applying: Add RBAC check on Create a Project link in all-namespaces pages
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/locales/en/devconsole.json
A	frontend/packages/dev-console/src/components/builds/BuildsTabListPage.tsx
M	frontend/packages/helm-plugin/locales/en/helm-plugin.json
M	frontend/packages/pipelines-plugin/locales/en/pipelines-plugin.json
M	frontend/packages/pipelines-plugin/src/components/pipelines/PipelineTabbedPage.tsx
M	frontend/packages/topology/locales/en/topology.json
M	frontend/packages/topology/src/components/page/TopologyPage.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/topology/src/components/page/TopologyPage.tsx
CONFLICT (content): Merge conflict in frontend/packages/topology/src/components/page/TopologyPage.tsx
Auto-merging frontend/packages/topology/locales/en/topology.json
Auto-merging frontend/packages/pipelines-plugin/src/components/pipelines/PipelineTabbedPage.tsx
Auto-merging frontend/packages/pipelines-plugin/locales/en/pipelines-plugin.json
Auto-merging frontend/packages/helm-plugin/locales/en/helm-plugin.json
CONFLICT (content): Merge conflict in frontend/packages/helm-plugin/locales/en/helm-plugin.json
CONFLICT (modify/delete): frontend/packages/dev-console/src/components/builds/BuildsTabListPage.tsx deleted in HEAD and modified in Add RBAC check on Create a Project link in all-namespaces pages. Version Add RBAC check on Create a Project link in all-namespaces pages of frontend/packages/dev-console/src/components/builds/BuildsTabListPage.tsx left in tree.
Auto-merging frontend/packages/dev-console/locales/en/devconsole.json
CONFLICT (content): Merge conflict in frontend/packages/dev-console/locales/en/devconsole.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add RBAC check on Create a Project link in all-namespaces pages
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

manual cherry-pick PR #12566

@vikram-raj vikram-raj deleted the cherry-pick-12489-to-release-4.11 branch February 14, 2023 17:55
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.10.0-0.nightly-2023-04-22-205546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/dev-console Related to dev-console component/helm Related to helm-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.