Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-10884: add multipath device type to LocalVolumeSet #12723

Merged
merged 1 commit into from Jul 11, 2023

Conversation

RomanBednar
Copy link
Contributor

Local Storage Operator supports multipath aside from disk and partition device types for LocalVolumeSet. If multipath option is missing, users can not specify it in the console when creating LocalVolumeSet and have to edit the object manually later if they want to use multipath.

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Apr 14, 2023
@openshift-ci-robot
Copy link
Contributor

@RomanBednar: This pull request references Jira Issue OCPBUGS-10884, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Local Storage Operator supports multipath aside from disk and partition device types for LocalVolumeSet. If multipath option is missing, users can not specify it in the console when creating LocalVolumeSet and have to edit the object manually later if they want to use multipath.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 14, 2023
@openshift-ci openshift-ci bot added the component/lso Related to local-storage-operator-plugin label Apr 14, 2023
@RomanBednar
Copy link
Contributor Author

/hold until openshift/local-storage-operator#394 is merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@RomanBednar
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2023
@RomanBednar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 23, 2023
@openshift-ci-robot
Copy link
Contributor

@RomanBednar: This pull request references Jira Issue OCPBUGS-10884, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RomanBednar
Copy link
Contributor Author

cc @openshift/hybrid-application-console-maintainers for review

@RomanBednar
Copy link
Contributor Author

cc @jhadvig for review

@RomanBednar
Copy link
Contributor Author

/assign @jhadvig

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 63510ec into openshift:master Jul 11, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@RomanBednar: Jira Issue OCPBUGS-10884: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10884 has been moved to the MODIFIED state.

In response to this:

Local Storage Operator supports multipath aside from disk and partition device types for LocalVolumeSet. If multipath option is missing, users can not specify it in the console when creating LocalVolumeSet and have to edit the object manually later if they want to use multipath.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/lso Related to local-storage-operator-plugin jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants