[WIP] CONSOLE-3568: Expose DeleteModal component in console-dynamic-plugin-sdk

[jhadvig]

Exposing a minimal version of the DeleteModal as a ResourceDeleteModa so it does not conflict with original component. This new component only handles a single resource and is not as robust as the original DeleteModal.

Action items:

• Expose the DeleteModal component in our console-dynamic-plugin-sdk as a ResourceDeleteModal
• Decouple the functionality console internal codebase.
• Use the new ResourceDeleteModal in parts of the code base where it would make delete action over a single resource
• Review the new component's API before merge
• Add TS docs the migrated DeleteModal component

/assign @vojtechszocs @TheRealJon

[openshift-ci-robot]

@jhadvig: This pull request references CONSOLE-3568 which is a valid jira issue.

In response to this:

Exposing a minimal version of the DeleteModal as a ResourceDeleteModa so it does not conflict with original component. This new component only handles a single resource and is not as robust as the original DeleteModal.

Action items:

• Expose the DeleteModal component in our console-dynamic-plugin-sdk as a ResourceDeleteModal
• Decouple the functionality console internal codebase.
• Use the original new ResourceDeleteModal in parts of the code base where it would make delete action over a single resrouce
• Review the new component's API before merge
• Add TS docs the migrated DeleteModal component

/assign @vojtechszocs @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/console-dynamic-plugin-sdk/OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jhadvig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	387ddd8	link	true	/test images
ci/prow/analyze	387ddd8	link	true	/test analyze
ci/prow/backend	387ddd8	link	true	/test backend
ci/prow/e2e-gcp-console	387ddd8	link	true	/test e2e-gcp-console
ci/prow/frontend	387ddd8	link	true	/test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[spadgett]

Should we expose the modal or the action itself? It would be good to expose the action so that callers don't need to manage display of the modal and we can change the implementation later if we want, although that probably means we need to expose at least some components from kebab.tsx.

[spadgett]

Did we copy the code here? It would be better to avoid duplicate code.

[jhadvig]

No the code has been written as for minimal valiable component. The original delete modal component is DeleteModal, this one since its just for a single resource deletion I've names ResourceDeleteModal.

[gnunn1]

Is it possible to have this support the propagation policy feature (i.e. non-cascading delete) of the internal delete dialog? I'm working on a plugin for OpenShift GitOps and deleting the dependent objects can be catastrophic for customers so supporting this option would be greatly appreciated.

Addionally from a visual perspective it looks odd that the internal dialog has this option but the plugin one would not.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gnunn1]

Also does the history.push need to be optional, i.e. if I call this from a kebob menu in a list of resources I don't think the history push is desirable for delete?

[openshift-ci-robot]

@jhadvig: This pull request references CONSOLE-3568 which is a valid jira issue.

In response to this:

Exposing a minimal version of the DeleteModal as a ResourceDeleteModa so it does not conflict with original component. This new component only handles a single resource and is not as robust as the original DeleteModal.

Action items:

• Expose the DeleteModal component in our console-dynamic-plugin-sdk as a ResourceDeleteModal
• Decouple the functionality console internal codebase.
• Use the new ResourceDeleteModal in parts of the code base where it would make delete action over a single resource
• Review the new component's API before merge
• Add TS docs the migrated DeleteModal component

/assign @vojtechszocs @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

Is it possible to have this support the propagation policy feature (i.e. non-cascading delete) of the internal delete dialog? I'm working on a plugin for OpenShift GitOps and deleting the dependent objects can be catastrophic for customers so supporting this option would be greatly appreciated.

Addionally from a visual perspective it looks odd that the internal dialog has this option but the plugin one would not.

@jhadvig, can you provide insight as to why the decision was made to have the new modal only handle a single resource?

[rhamilto]

Also does the history.push need to be optional, i.e. if I call this from a kebob menu in a list of resources I don't think the history push is desirable for delete?

Agreed. Will make the history.push only occur if on the resource details page like the existing modal does.

[rhamilto]

This PR is being replaced with #12974.