Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-3568: expose DeleteModal via useDeleteModal hook in @console/shared #12974

Merged
merged 1 commit into from
Jul 31, 2023
Merged

CONSOLE-3568: expose DeleteModal via useDeleteModal hook in @console/shared #12974

merged 1 commit into from
Jul 31, 2023

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jul 5, 2023 •
edited
Loading

Screen.Recording.2023-07-27.at.3.17.01.PM.mov

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 5, 2023 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-3568 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 5, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 5, 2023
@rhamilto rhamilto mentioned this pull request Jul 6, 2023
Closed
5 tasks
@rhamilto rhamilto force-pushed the CONSOLE-3568 branch 5 times, most recently from d1c2aef to 3520796 Compare July 11, 2023 13:34
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2023 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-3568 which is a valid jira issue.

In response to this:

Includes changes from #13018, which should merge first as the commits it contains will get squashed on merge.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto changed the title [WIP] CONSOLE-3568: Expose DeleteModal component in console-dynamic-plugin-sdk [WIP] CONSOLE-3568: expose DeleteModal via useDeleteModal hook in @console/shared Jul 17, 2023
@rhamilto
Copy link
Member Author

/retest

@rhamilto rhamilto force-pushed the CONSOLE-3568 branch 3 times, most recently from 9f2da9e to e21eaa2 Compare July 19, 2023 19:40
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 27, 2023 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-3568 which is a valid jira issue.

In response to this:

Includes changes from #13018, which should merge first as the commits it contains will get squashed on merge.

Screen.Recording.2023-07-27.at.3.17.01.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto
Copy link
Member Author

This is internal Console code cleanup and has no user-facing impact.

/assign @TheRealJon for code approval
/assign @yanpzhan for QE approval
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 27, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2023
@yanpzhan
Copy link
Contributor

@rhamilto could you pls rebase the pr so that cluster-bot can launch cluster against it?

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 28, 2023 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-3568 which is a valid jira issue.

In response to this:

Screen.Recording.2023-07-27.at.3.17.01.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto changed the title [WIP] CONSOLE-3568: expose DeleteModal via useDeleteModal hook in @console/shared CONSOLE-3568: expose DeleteModal via useDeleteModal hook in @console/shared Jul 28, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2023
@rhamilto
Copy link
Member Author

@rhamilto could you pls rebase the pr so that cluster-bot can launch cluster against it?

Done.

TheRealJon
TheRealJon approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

frontend/public/components/modals/delete-modal.tsx

props.handlePromise(k8sKill(kind, resource, {}, {}, json), () => {
props.close();
props?.close && props.close();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
props?.close && props.close();
props?.close?.();

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanpzhan
Copy link
Contributor

Did a regression test on the cluster launched against the pr, especially tested about resource deletion, there is no regression issue.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 80bf966 into openshift:master Jul 31, 2023
6 checks passed
@rhamilto rhamilto deleted the CONSOLE-3568 branch July 31, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@yanpzhan yanpzhan

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/sdk Related to console-plugin-sdk component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rhamilto @openshift-ci-robot @yanpzhan @TheRealJon @openshift-merge-robot