Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14716: add ROSA branding option #12889

Merged
merged 1 commit into from Jun 16, 2023
Merged

OCPBUGS-14716: add ROSA branding option #12889

merged 1 commit into from Jun 16, 2023

Conversation

rhamilto
Copy link
Member

localhost_9000_dashboards
localhost_9000_dashboards (1)
Screenshot 2023-06-12 at 2 23 42 PM

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 12, 2023
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-14716, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yanpzhan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

localhost_9000_dashboards
localhost_9000_dashboards (1)
Screenshot 2023-06-12 at 2 23 42 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yanpzhan June 12, 2023 18:26
@openshift-ci openshift-ci bot added component/backend Related to backend component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 12, 2023
@rhamilto
Copy link
Member Author

/retest

1 similar comment
@rhamilto
Copy link
Member Author

/retest

jhadvig
jhadvig approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Merging this PR would require manual testing since console-operator config needs to get updated first since the branding is set though the operator.
Here is the PR for that.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b9185dd and 2 for PR HEAD f783d87 in total

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 15, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b01119c and 1 for PR HEAD f783d87 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fa08df4 and 0 for PR HEAD f783d87 in total

@rhamilto
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ca38136 into openshift:master Jun 16, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@rhamilto: Jira Issue OCPBUGS-14716: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-14716 has not been moved to the MODIFIED state.

In response to this:

localhost_9000_dashboards
localhost_9000_dashboards (1)
Screenshot 2023-06-12 at 2 23 42 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto deleted the OCPBUGS-14716 branch June 17, 2023 12:56
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 11, 2023
Merged
wking added a commit to wking/openshift-console that referenced this pull request Sep 21, 2023
@wking
frontend/packages/console-shared/src/hooks/useCanClusterUpgrade: Not …
9d11ec6 
…ROSA

ROSA cluster updates are via OCM [1]:

  There are three methods to upgrade Red Hat OpenShift Service on AWS (ROSA) clusters:

  * Individual upgrades through the ROSA CLI (rosa)
  * Individual upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console
  * Recurring upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console

This is similar to OpenShift Dedicated (OSD) [2], although there is no
OSD command-line client analogous to 'rosa'.  This catches this one
function up with f783d87 (OCPBUGS-14716: add ROSA branding option,
2023-06-12, openshift#12889), although I have not audited to see if there are
other branding consumers that might want similar updates.

[1]: https://docs.openshift.com/rosa/upgrading/rosa-upgrading.html#rosa-sts-upgrading-a-cluster
[2]: https://docs.openshift.com/dedicated/upgrading/osd-upgrades.html
@wking wking mentioned this pull request Sep 21, 2023
Merged
wking added a commit to wking/openshift-console that referenced this pull request Sep 22, 2023
@wking
frontend/packages/console-shared/src/hooks/useCanClusterUpgrade: Not …
b7261e9 
…ROSA

ROSA cluster updates are via OCM [1]:

  There are three methods to upgrade Red Hat OpenShift Service on AWS (ROSA) clusters:

  * Individual upgrades through the ROSA CLI (rosa)
  * Individual upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console
  * Recurring upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console

This is similar to OpenShift Dedicated (OSD) [2], although there is no
OSD command-line client analogous to 'rosa'.  This catches this one
function up with f783d87 (OCPBUGS-14716: add ROSA branding option,
2023-06-12, openshift#12889), although I have not audited to see if there are
other branding consumers that might want similar updates.

[1]: https://docs.openshift.com/rosa/upgrading/rosa-upgrading.html#rosa-sts-upgrading-a-cluster
[2]: https://docs.openshift.com/dedicated/upgrading/osd-upgrades.html
wking added a commit to wking/openshift-console that referenced this pull request Sep 22, 2023
@wking
frontend/packages/console-shared/src/hooks/useCanClusterUpgrade: Not …
ad7fc68 
…ROSA

ROSA cluster updates are via OCM [1]:

  There are three methods to upgrade Red Hat OpenShift Service on AWS (ROSA) clusters:

  * Individual upgrades through the ROSA CLI (rosa)
  * Individual upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console
  * Recurring upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console

This is similar to OpenShift Dedicated (OSD) [2], although there is no
OSD command-line client analogous to 'rosa'.  This catches this one
function up with f783d87 (OCPBUGS-14716: add ROSA branding option,
2023-06-12, openshift#12889), although I have not audited to see if there are
other branding consumers that might want similar updates.

[1]: https://docs.openshift.com/rosa/upgrading/rosa-upgrading.html#rosa-sts-upgrading-a-cluster
[2]: https://docs.openshift.com/dedicated/upgrading/osd-upgrades.html
@rhamilto rhamilto mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@yanpzhan yanpzhan Awaiting requested review from yanpzhan

@florkbr florkbr Awaiting requested review from florkbr

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhamilto @openshift-ci-robot @jhadvig @openshift-merge-robot