CONSOLE-3084: frontend/packages/console-shared/src/hooks/useCanClusterUpgrade: Not ROSA

[wking]

ROSA cluster updates are via OCM:

There are three methods to upgrade Red Hat OpenShift Service on AWS (ROSA) clusters:

• Individual upgrades through the ROSA CLI (rosa)
• Individual upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console
• Recurring upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console

This is similar to OpenShift Dedicated (OSD), although there is no OSD command-line client analogous to rosa. This catches this one function up with f783d87 (#12889), CC @rhamilto, although I have not audited to see if there are other branding consumers that might want similar updates.

[openshift-ci-robot]

@wking: This pull request references CONSOLE-3084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

ROSA cluster updates are via OCM:

There are three methods to upgrade Red Hat OpenShift Service on AWS (ROSA) clusters:

• Individual upgrades through the ROSA CLI (rosa)
• Individual upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console
• Recurring upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console

This is similar to OpenShift Dedicated (OSD), although there is no OSD command-line client analogous to rosa. This catches this one function up with f783d87 (#12889), CC @rhamilto, although I have not audited to see if there are other branding consumers that might want similar updates.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

Thanks, @wking. Note the rosa branding option is new-ish. Will want to work with the packaging team to make sure they are using it, otherwise this fix won't work.

[rhamilto]

/lgtm

[wking]

Neither failure seems relevant, and pull-ci-openshift-console-master-e2e-gcp-console seems pretty dead, but:

/retest-required

[jhadvig]

@wking you need to run yarn prettier-all to properly format the changes

[wking]

I don't have yarn installed locally, and CI:

/go/src/github.com/openshift/console/frontend/packages/console-shared/src/hooks/useCanClusterUpgrade.ts
  16:33  error  Insert `⏎···`  prettier/prettier
  17:28  error  Insert `⏎···`  prettier/prettier

suggests line wrapping, but doesn't print a convenient diff for me to apply as a patch. But I've taken a guess and pushed 9d11ec6 -> b7261e9.

[rhamilto]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhamilto]

/retest

[rhamilto]

QE Approver:

/assign @yanpzhan
PX Approver:
/assign @RickJWagner
Docs Approver:
/assign @opayne1

[opayne1]

/label docs-approved

[RickJWagner]

/label px-approved

[yanpzhan]

/label qe-approved

[openshift-ci-robot]

@wking: This pull request references CONSOLE-3084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

ROSA cluster updates are via OCM:

There are three methods to upgrade Red Hat OpenShift Service on AWS (ROSA) clusters:

• Individual upgrades through the ROSA CLI (rosa)
• Individual upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console
• Recurring upgrades through the OpenShift Cluster Manager Hybrid Cloud Console console

This is similar to OpenShift Dedicated (OSD), although there is no OSD command-line client analogous to rosa. This catches this one function up with f783d87 (#12889), CC @rhamilto, although I have not audited to see if there are other branding consumers that might want similar updates.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.