Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-3816: Goodbye! #13255

Merged
merged 1 commit into from Oct 25, 2023
Merged

CONSOLE-3816: Goodbye! #13255

merged 1 commit into from Oct 25, 2023

Conversation

bipuladh
Copy link
Contributor

Removes Ceph static plugin from OCP console repository
Screenshot:
Screenshot from 2023-10-17 14-07-38

@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 17, 2023
@openshift-ci openshift-ci bot added the component/metal3 Related to metal3-plugin label Oct 17, 2023
@bipuladh
Copy link
Contributor Author

/assign @spadgett

jhadvig
jhadvig approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bipuladh 🙌
/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2023
@rhamilto
Copy link
Member

#13249 merged first, resulting in conflicts. Rebase will be required. Sorry, @bipuladh.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2023
@bipuladh
Removes Ceph static plugin from OCP console repository
07cfceb 
Signed-off-by: Bipul Adhikari <badhikar@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2023
@bipuladh bipuladh changed the title Goodbye! CONSOLE-3816: Goodbye! Oct 23, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2023 •
edited by openshift-ci bot

@bipuladh: This pull request references CONSOLE-3816 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Removes Ceph static plugin from OCP console repository
Screenshot:
Screenshot from 2023-10-17 14-07-38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto
Copy link
Member

/lgtm

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, jhadvig, rhamilto, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

@bipuladh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bipuladh
Copy link
Contributor Author

/label docs-approved
/label qe-approved
/label px-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Oct 25, 2023
@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 25, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 25, 2023 •
edited by openshift-ci bot

@bipuladh: This pull request references CONSOLE-3816 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Removes Ceph static plugin from OCP console repository
Screenshot:
Screenshot from 2023-10-17 14-07-38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

/label px-approved

@openshift-ci openshift-ci bot merged commit 8a3c4f0 into openshift:master Oct 25, 2023
6 checks passed
@rhamilto rhamilto mentioned this pull request Oct 25, 2023
Merged
@SanjalKatiyar SanjalKatiyar mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@SanjalKatiyar SanjalKatiyar SanjalKatiyar approved these changes

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@rhamilto rhamilto

@spadgett spadgett

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/metal3 Related to metal3-plugin docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bipuladh @rhamilto @openshift-ci-robot @jhadvig @SanjalKatiyar @spadgett @openshift-merge-robot