Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-25881: remove "openshift-storage" namespace usage from the console #13418

Merged
merged 1 commit into from Jan 29, 2024
Merged

OCPBUGS-25881: remove "openshift-storage" namespace usage from the console #13418

merged 1 commit into from Jan 29, 2024
+31 −23

Conversation

SanjalKatiyar
Copy link
Contributor

  • "openshift-storage" namespace is specific to "OpenShift Data Foundation" operator and should not be used in OCP console.
  • We have also removed Ceph static plugin from OCP console repository (CONSOLE-3816: Goodbye! #13255), this PR can be regarded as further minor cleanup.
  • ODF operator can now be installed in other namespaces as well, so csi provisioner will not always be pre-fixed with "openshift-storage".
Screenshot 2023-12-07 at 3 37 41 PM Screenshot 2023-12-07 at 3 38 50 PM Screenshot 2023-12-07 at 3 40 04 PM

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared labels Dec 7, 2023
@SanjalKatiyar
Copy link
Contributor Author

/assign @bipuladh

@SanjalKatiyar
Copy link
Contributor Author

/retitle OCPBUGS-25881: remove "openshift-storage" namespace usage from the console

@openshift-ci openshift-ci bot changed the title remove "openshift-storage" namespace usage from the console OCPBUGS-25881: remove "openshift-storage" namespace usage from the console Dec 26, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 26, 2023
@openshift-ci-robot
Copy link
Contributor

@SanjalKatiyar: This pull request references Jira Issue OCPBUGS-25881, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • "openshift-storage" namespace is specific to "OpenShift Data Foundation" operator and should not be used in OCP console.
  • We have also removed Ceph static plugin from OCP console repository (CONSOLE-3816: Goodbye! #13255), this PR can be regarded as further minor cleanup.
  • ODF operator can now be installed in other namespaces as well, so csi provisioner will not always be pre-fixed with "openshift-storage".
Screenshot 2023-12-07 at 3 37 41 PM Screenshot 2023-12-07 at 3 38 50 PM Screenshot 2023-12-07 at 3 40 04 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 26, 2023
@SanjalKatiyar
Copy link
Contributor Author

@bipuladh PTAL.

bipuladh
bipuladh approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
cc @jhadvig @spadgett

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@SanjalKatiyar
Copy link
Contributor Author

/test e2e-gcp-console

2 similar comments
@SanjalKatiyar
Copy link
Contributor Author

/test e2e-gcp-console

@SanjalKatiyar
Copy link
Contributor Author

/test e2e-gcp-console

jhadvig
jhadvig approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, jhadvig, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3e46a5a and 2 for PR HEAD fd10cff in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a3b2364 and 1 for PR HEAD fd10cff in total

@SanjalKatiyar
Copy link
Contributor Author

/retest-required

@SanjalKatiyar
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SanjalKatiyar
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

@SanjalKatiyar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 76ffc72 into openshift:master Jan 29, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@SanjalKatiyar: Jira Issue OCPBUGS-25881: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25881 has been moved to the MODIFIED state.

In response to this:

  • "openshift-storage" namespace is specific to "OpenShift Data Foundation" operator and should not be used in OCP console.
  • We have also removed Ceph static plugin from OCP console repository (CONSOLE-3816: Goodbye! #13255), this PR can be regarded as further minor cleanup.
  • ODF operator can now be installed in other namespaces as well, so csi provisioner will not always be pre-fixed with "openshift-storage".
Screenshot 2023-12-07 at 3 37 41 PM Screenshot 2023-12-07 at 3 38 50 PM Screenshot 2023-12-07 at 3 40 04 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@SanjalKatiyar: new pull request created: #13548

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 29, 2024
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202401290813.p0.g76ffc72.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-01-31-073538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@bipuladh bipuladh bipuladh approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SanjalKatiyar @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot @openshift-merge-robot @jhadvig @bipuladh