ODC-7409: Use @kubernetes-models/shipwright types in shipwright-plugin #13267
Conversation
openshift-ci
bot
requested review from
jhadvig,
lokanandaprabhu,
Lucifergene,
spadgett and
vikram-raj
openshift-ci
bot
added
do-not-merge/work-in-progress
jerolimov
force-pushed
the
use-kubernetes-models-shipwright
branch
from
ea523ef
to
d800289
Compare
jerolimov
force-pushed
the
use-kubernetes-models-shipwright
branch
from
d800289
to
2776599
Compare
|
/retest |
jerolimov
changed the title
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@jerolimov: This pull request references ODC-7353 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Just type updates. This doesn't touch the project or tests. /label px-approved |
openshift-ci
bot
added
px-approved
|
@jerolimov: This pull request references ODC-7353 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jerolimov
changed the title
|
@jerolimov: This pull request references ODC-7409 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@jerolimov: This pull request references ODC-7409 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@jerolimov: This pull request references ODC-7409 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Thanks @jerolimov it is a nice improvement it would be nice to do the same for other packages/resources.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jerolimov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Use CRD-generated types instead of manual written types in the shipwright-plugin.
See:
@kubernetes-models/shipwright0.2.0 types are generated based on the shipwright 0.12.0 CRDs:/cc @Lucifergene @lokanandaprabhu @vikram-raj @spadgett @jhadvig