Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-24196: ApiVersion displayed on console is v1alpha1 whereas we support v1beta1 #13402

Conversation

Lucifergene
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/OCPBUGS-24196

Analysis / Root cause:
While creating a build via console, the YAML of build or buildRun switched to shipwright.io/v1alpha1 version, whereas we support shipwright.io/v1beta1 with GA.

Solution Description:
Cherry-picked PRs #13304 & #13267 from 4.15

Screen shots / Gifs for design review:

Tab-sw-deployment-example-build.Build.Details.OKD.mp4

Unit test coverage report:
Unchanged.

Test setup:
As per Jira Ticket.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 4, 2023
@openshift-ci-robot
Copy link
Contributor

@Lucifergene: This pull request references Jira Issue OCPBUGS-24196, which is invalid:

  • expected Jira Issue OCPBUGS-24196 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-24196

Analysis / Root cause:
While creating a build via console, the YAML of build or buildRun switched to shipwright.io/v1alpha1 version, whereas we support shipwright.io/v1beta1 with GA.

Solution Description:
Cherry-picked PRs #13304 & #13267 from 4.15

Screen shots / Gifs for design review:

Tab-sw-deployment-example-build.Build.Details.OKD.mp4

Unit test coverage report:
Unchanged.

Test setup:
As per Jira Ticket.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Dec 4, 2023
@Lucifergene
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2023

@Lucifergene: This pull request references Jira Issue OCPBUGS-24196, which is invalid:

  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • bug has dependents
  • dependent bug ODC-7409 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Lucifergene
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2023

@Lucifergene: This pull request references Jira Issue OCPBUGS-24196, which is invalid:

  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24367 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-24367 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents
  • dependent bug ODC-7414 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Lucifergene
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 4, 2023
@openshift-ci-robot
Copy link
Contributor

@Lucifergene: This pull request references Jira Issue OCPBUGS-24196, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24367 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-24367 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Lucifergene
Copy link
Contributor Author

@openshift-ci openshift-ci bot requested review from jerolimov and lokanandaprabhu and removed request for kyoto and divyanshiGupta December 4, 2023 07:41
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this backport against two clusters:

  1. Local console with this PR on an OpenShift Local 4.13.6 with Shipwright Operator 0.9.0 to verify it still works with v1alpha1 ✔️
  2. Local console with this PR on a Cluster bot instance with 4.14.0-0.nightly-2023-12-03-135752 and Builds for Red Hat OpenShift operator 1.0.0 to verify it works now also with v1beta1 ✔️

/label backport-risk-assessed
/lgtm
/approve

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 4, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@sanketpathak
Copy link
Contributor

/label qe-approved

@sanketpathak
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 4, 2023
@openshift-ci-robot
Copy link
Contributor

@Lucifergene: This pull request references Jira Issue OCPBUGS-24196, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24367 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-24367 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-24196

Analysis / Root cause:
While creating a build via console, the YAML of build or buildRun switched to shipwright.io/v1alpha1 version, whereas we support shipwright.io/v1beta1 with GA.

Solution Description:
Cherry-picked PRs #13304 & #13267 from 4.15

Screen shots / Gifs for design review:

Tab-sw-deployment-example-build.Build.Details.OKD.mp4

Unit test coverage report:
Unchanged.

Test setup:
As per Jira Ticket.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 4, 2023
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 67d4766 into openshift:release-4.14 Dec 4, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@Lucifergene: Jira Issue OCPBUGS-24196: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24196 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-24196

Analysis / Root cause:
While creating a build via console, the YAML of build or buildRun switched to shipwright.io/v1alpha1 version, whereas we support shipwright.io/v1beta1 with GA.

Solution Description:
Cherry-picked PRs #13304 & #13267 from 4.15

Screen shots / Gifs for design review:

Tab-sw-deployment-example-build.Build.Details.OKD.mp4

Unit test coverage report:
Unchanged.

Test setup:
As per Jira Ticket.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.14.0-202312041332.p0.g67d4766.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-12-04-211409

@jerolimov
Copy link
Member

/retitle [release-4.14] OCPBUGS-24196: ApiVersion displayed on console is v1alpha1 whereas we support v1beta1

@openshift-ci openshift-ci bot changed the title OCPBUGS-24196: ApiVersion displayed on console is v1alpha1 whereas we support v1beta1 [release-4.14] OCPBUGS-24196: ApiVersion displayed on console is v1alpha1 whereas we support v1beta1 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/dev-console Related to dev-console jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet