OCPBUGS-23378: Set min-width for PF popovers that are being overridden by an inline style #13390
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@sg00dwin: This pull request references Jira Issue OCPBUGS-23378, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
component/core
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@sg00dwin: This pull request references Jira Issue OCPBUGS-23378, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sg00dwin
changed the title
| @@ -399,3 +399,8 @@ ul.pf-v5-c-tree-view__list { | |||
| color: var(--pf-global--Color--100); | |||
| background-color: var(--pf-global--palette--black-600); | |||
| } | |||
|
|
|||
| // PF5 Popover component applies an new inline width:auto style that overrides it's own pf-v5-c-popover min-width: var(--pf-v5-c-popover--MinWidth). So the pf-v5-c-popover container is not a consistent size and can resize when additional content is loaded which causes the alignment to be incorrect. | |||
There was a problem hiding this comment.
Is there an upstream bug we can include a link to?
There was a problem hiding this comment.
Their isn't yet. I relayed my findings to @nicolethoen on the PatternFly team who was going to do some more investigations.
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, sg00dwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sg00dwin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@sg00dwin: Jira Issue OCPBUGS-23378: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23378 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.15.0-202312051932.p0.g5a9abcc.assembly.stream for distgit openshift-enterprise-console. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-12-07-041003 |
Because of a difference between PF4 and PF5, their
Popovercomponent is now adding an inlinewidth: autoto thepf-v5-c-popovercontainer, which is overriding their PF variablemin-width: var(--pf-v5-c-popover--MinWidth)(which is calculated the same asmax-width: var(--pf-v5-c-popover--MaxWidth)). So what happens is thepf-v5-c-popovercontainer can load at smaller width and resize larger when delayed content is loaded, which is then not aligned correctly.Popover with incorrect position and the inline
width: autoPopover fixed when
min-width: var(--pf-v5-c-popover--MinWidth) !important;applied