OCPBUGS-23378: Prevent text overlap with popover close button on Create NetworkPolicy form

[sg00dwin]

before

after

[openshift-ci-robot]

@sg00dwin: This pull request references Jira Issue OCPBUGS-23378, which is invalid:

• expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

before

after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

Is this not an issue in all Popovers?

I believe this is a one off. I searched and did not find another Popover that is constructed in this manner... where the headerContent={<p />}, even though empty, is still being generated. And as such it is receiving the padding-right that PF applies to allow room for the X button. Because of this <div class="pf-v5-c-popover__body" is allowed to be full width and the text overlaps the button.

.pf-v5-c-popover__close + * {
    padding-inline-end: var(--pf-v5-c-popover__close--sibling--PaddingRight);
}```

[sg00dwin]

/jira refresh

[openshift-ci-robot]

@sg00dwin: This pull request references Jira Issue OCPBUGS-23378, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

/lgtm

Thank you for not adding a hack on top of a hack!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/console-app/src/components/network-policies/OWNERS [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8e68a56 and 2 for PR HEAD f5b70c4 in total

[openshift-ci]

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@sg00dwin: Jira Issue OCPBUGS-23378: All pull requests linked via external trackers have merged:

• openshift/console#13390
• openshift/console#13429

Jira Issue OCPBUGS-23378 has been moved to the MODIFIED state.

In response to this:

before

after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202312091832.p0.g75f578a.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.