Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-28967: 'Oh no somthing went wrong' shown on Image Manifest Vulnerability page after create IMV via CL #13578

Merged
merged 2 commits into from Feb 22, 2024
Merged

OCPBUGS-28967: 'Oh no somthing went wrong' shown on Image Manifest Vulnerability page after create IMV via CL #13578

merged 2 commits into from Feb 22, 2024

Conversation

cyril-ui-developer
Copy link
Contributor

@cyril-ui-developer cyril-ui-developer commented Feb 5, 2024 •
edited

Before:

Screenshot 2024-02-05 at 5 20 03 PM

After:

Screenshot 2024-02-06 at 12 53 10 PM

Screenshot 2024-02-21 at 8 34 05 AM

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 5, 2024
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-28967, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before:

Screenshot 2024-02-05 at 5 20 03 PM

After:

Screenshot 2024-02-05 at 5 19 12 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cyril-ui-developer
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 5, 2024
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-28967, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from XiyunZhao February 5, 2024 22:35
@cyril-ui-developer
Copy link
Contributor Author

/retest

jhadvig
jhadvig reviewed Feb 6, 2024
View reviewed changes
frontend/packages/container-security/src/components/summary.tsx
.split('/')
.reduce((url, part, i) => [...url, part, ...(i === 0 ? ['repository'] : [])], [])
.join('/')}/manifest/${vuln.spec?.manifest}?tab=vulnerabilities`
: '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are returning an empty string then we should check the usage and not render the link if the URL is empty

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-28967, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

In response to this:

Before:

Screenshot 2024-02-05 at 5 20 03 PM

After:

Screenshot 2024-02-06 at 12 53 10 PM

Screenshot 2024-02-06 at 12 53 20 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cyril-ui-developer cyril-ui-developer force-pushed the oh-something-went-wrong-imgmanifastvul-page branch from 26f7cec to 7f654f1 Compare February 6, 2024 17:55
@cyril-ui-developer
Copy link
Contributor Author

/retest

1 similar comment
@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

@jhadvig Updated, PTAL.

@cyril-ui-developer
Copy link
Contributor Author

/retest

jhadvig
jhadvig reviewed Feb 9, 2024
View reviewed changes
frontend/packages/container-security/src/components/image-manifest-vuln.tsx Outdated
text={shortenHash(props.obj.spec.manifest)}
href={quayURLFor(props.obj)}
/>
{queryURL ? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behaviour should be to render the DetailsItem only if there is value to render

Suggested change
{queryURL ? (
{queryURL && (
<ExternalLink text={shortenHash(props.obj.spec.manifest)} href={queryURL} />
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behaviour should be to render the DetailsItem only if there is value to render

@jhadvig Hmm, not sure if that is doable without duplicating the label.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyril-ui-developer which label do you mean ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DetailsItem

@jhadvig The DetailItem component provides the label for displaying the item. So if we don't render it, we'll have to duplicate the label some how for the default empty string to have a label caption when it is rendered.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion, I mean we should be conditioning the DetailsItem component with queryURL.

@cyril-ui-developer cyril-ui-developer force-pushed the oh-something-went-wrong-imgmanifastvul-page branch from 7f654f1 to bb85cdf Compare February 9, 2024 20:51
@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer cyril-ui-developer force-pushed the oh-something-went-wrong-imgmanifastvul-page branch from bb85cdf to f401207 Compare February 13, 2024 14:26
@cyril-ui-developer
Copy link
Contributor Author

/retest

5 similar comments
@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/retest

jhadvig
jhadvig approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9b4800d into openshift:master Feb 22, 2024
5 of 6 checks passed
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: Jira Issue OCPBUGS-28967: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28967 has been moved to the MODIFIED state.

In response to this:

Before:

Screenshot 2024-02-05 at 5 20 03 PM

After:

Screenshot 2024-02-06 at 12 53 10 PM

Screenshot 2024-02-21 at 8 34 05 AM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-22-180402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

@XiyunZhao XiyunZhao Awaiting requested review from XiyunZhao

Assignees

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cyril-ui-developer @openshift-ci-robot @openshift-merge-robot @jhadvig