OCPBUGS-30575,OCPBUGS-30052: PipelineRuns in Console show wrong status or load indefinitely

[lokanandaprabhu]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-30575
https://issues.redhat.com/browse/OCPBUGS-30052

Analysis / Root cause:
If there is no TaskRun, loading icon is added and for failed PLR and when there are no taskruns, it was showing Loading icon indefinitely

Solution Description:
Updated component to check if taskRuns are loaded and if the resources are loaded then don't add loading icon indefinitely

Screen shots / Gifs for design review:

----BEFORE----

Screen.Recording.2024-03-08.at.12.56.35.PM.mov

----AFTER----

Screen.Recording.2024-03-08.at.12.58.49.PM.mov

Unit test coverage report:
NA

Test setup:

1. Create Task hello, TaskRun hello-task-run from https://tekton.dev/docs/getting-started/tasks/
2. Create Task goodbye, Pipeline hello-goodbye and PipelineRun hello-goodbye-run from https://tekton.dev/docs/getting-started/pipelines/
3. Create another Pipeline and use an invalid TaskRun ref name
4. For the pending PipelineRun, create another PipelineRun using below spec, https://tekton.dev/docs/pipelines/pipelineruns/#pending-pipelineruns

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-30575, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-30052, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-30575
https://issues.redhat.com/browse/OCPBUGS-30052

Analysis / Root cause:
If there is no TaskRun, loading icon is added and for failed PLR and when there are no taskruns, it was showing Loading icon indefinitely

Solution Description:
Updated component to check if taskRuns are loaded and if the resources are loaded then don't add loading icon indefinitely

Screen shots / Gifs for design review:

----BEFORE----

Screen.Recording.2024-03-08.at.12.56.35.PM.mov

----AFTER----

Screen.Recording.2024-03-08.at.12.58.49.PM.mov

Unit test coverage report:
NA

Test setup:

1. Create Task hello, TaskRun hello-task-run from https://tekton.dev/docs/getting-started/tasks/
2. Create Task goodbye, Pipeline hello-goodbye and PipelineRun hello-goodbye-run from https://tekton.dev/docs/getting-started/pipelines/
3. Create another Pipeline and use an invalid TaskRun ref name
4. For the pending PipelineRun, create another PipelineRun using below spec, https://tekton.dev/docs/pipelines/pipelineruns/#pending-pipelineruns

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/jira refresh

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-30575, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-30052, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/cc @vikram-raj @jerolimov

[jerolimov]

Verified this on a cluster bot in the admin and dev perspective!

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerolimov]

@lokanandaprabhu The loading issue happen since 4.12, please backport this at least to 4.14 and 4.15. Thank you.

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 63e97fa and 2 for PR HEAD 05a2e23 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 824a736 and 1 for PR HEAD 05a2e23 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e56ab7e and 0 for PR HEAD 05a2e23 in total

[openshift-ci-robot]

/hold

Revision 05a2e23 was retested 3 times: holding

[lokanandaprabhu]

/unhold
/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5077253 and 2 for PR HEAD 05a2e23 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3bbcf7e and 1 for PR HEAD 05a2e23 in total

[openshift-ci]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@lokanandaprabhu: Jira Issue OCPBUGS-30575: All pull requests linked via external trackers have merged:

• openshift/console#13659

Jira Issue OCPBUGS-30575 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-30052: All pull requests linked via external trackers have merged:

• openshift/console#13659

Jira Issue OCPBUGS-30052 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-30575
https://issues.redhat.com/browse/OCPBUGS-30052

Analysis / Root cause:
If there is no TaskRun, loading icon is added and for failed PLR and when there are no taskruns, it was showing Loading icon indefinitely

Solution Description:
Updated component to check if taskRuns are loaded and if the resources are loaded then don't add loading icon indefinitely

Screen shots / Gifs for design review:

----BEFORE----

Screen.Recording.2024-03-08.at.12.56.35.PM.mov

----AFTER----

Screen.Recording.2024-03-08.at.12.58.49.PM.mov

Unit test coverage report:
NA

Test setup:

1. Create Task hello, TaskRun hello-task-run from https://tekton.dev/docs/getting-started/tasks/
2. Create Task goodbye, Pipeline hello-goodbye and PipelineRun hello-goodbye-run from https://tekton.dev/docs/getting-started/pipelines/
3. Create another Pipeline and use an invalid TaskRun ref name
4. For the pending PipelineRun, create another PipelineRun using below spec, https://tekton.dev/docs/pipelines/pipelineruns/#pending-pipelineruns

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@lokanandaprabhu: new pull request created: #13672

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.