Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Warning: React does not recognize the prop on a DOM element. #2675

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Fix Warning: React does not recognize the prop on a DOM element. #2675

merged 1 commit into from
Sep 13, 2019

Conversation

vikram-raj
Copy link
Member

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2019
@vikram-raj
Copy link
Member Author

cc @christianvogt

@christianvogt
Copy link
Contributor

This component exists for the sole purpose of providing an uncontrolled variant of the PF4 Expandable component. This was created before PF4 implemented their own uncontrolled variant.

We should remove this utility and use the PF4 Expandable directly. There seems to be 2 instances of the usage.

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2019
@vikram-raj
Copy link
Member Author

This component exists for the sole purpose of providing an uncontrolled variant of the PF4 Expandable component. This was created before PF4 implemented their own uncontrolled variant.

We should remove this utility and use the PF4 Expandable directly. There seems to be 2 instances of the usage.

@christianvogt I removed the expande-collapse component and using Expandable component directly gtom PF4.

vikram-raj
vikram-raj commented Sep 12, 2019
View reviewed changes
Copy link
Member Author

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@christianvogt
Copy link
Contributor

@vikram-raj ARGH i had no idea that PF4 didn't add support for the supplying two different text labels for expanded vs collapsed for their uncontrolled support! This defeats the whole purpose of using their uncontrolled component. Because now you're using the uncontrolled component but duplicating the state externally :( Wish you'd have mentioned this before refactoring.
I'm going to file yet another bug against PF4 on this.

@christianvogt
Copy link
Contributor

Since PF4 expandable still hasn't added the proper APIs please go back to only updating the expand-collapse component. I'd rather keep this component around until PF4 makes the proper updates.
Sorry to ask you to make this change again :(

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2019
@vikram-raj
Copy link
Member Author

Since PF4 expandable still hasn't added the proper APIs please go back to only updating the expand-collapse component. I'd rather keep this component around until PF4 makes the proper updates.
Sorry to ask you to make this change again :(

@christianvogt Done.

@christianvogt
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1cd931f into openshift:master Sep 13, 2019
@spadgett spadgett added this to the v4.2 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@vikram-raj @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot