Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with serverless image stream with tags #2876

Merged
merged 1 commit into from
Oct 3, 2019
Merged

fix issue with serverless image stream with tags #2876

merged 1 commit into from
Oct 3, 2019

Conversation

invincibleJai
Copy link
Member

fix issue with serverless image stream with tags

Tracks: https://jira.coreos.com/browse/ODC-1726

Steps:

  1. Click on Add "Container Image"
  2. Pass image "docker.io/mgencur/helloworld-go:0.1"
  3. Should work as expected

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2019
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2019
@invincibleJai
Copy link
Member Author

/test e2e-aws-console

@invincibleJai
Copy link
Member Author

/test e2e-aws-console-olm

@debsmita1
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2019
@debsmita1
Copy link
Contributor

/test e2e-aws-console-olm
/test e2e-aws-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

vikram-raj
vikram-raj approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@invincibleJai
Copy link
Member Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 3, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2019
vikram-raj
vikram-raj reviewed Oct 3, 2019
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, debsmita1, invincibleJai, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8d3e417 into openshift:master Oct 3, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

Assignees

@vikram-raj vikram-raj

@debsmita1 debsmita1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
8 participants
@invincibleJai @christianvogt @debsmita1 @openshift-bot @openshift-ci-robot @vikram-raj @spadgett @openshift-merge-robot