Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create route test #2999

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Add create route test #2999

merged 1 commit into from
Oct 18, 2019

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Oct 17, 2019 •
edited
Loading

Unit test for create route and alt services for route

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2019
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Oct 17, 2019
@jcaianirh
Copy link
Member Author

/test e2e-aws-console-olm

2 similar comments
@jcaianirh
Copy link
Member Author

/test e2e-aws-console-olm

@jcaianirh
Copy link
Member Author

/test e2e-aws-console-olm

spadgett
spadgett approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2019
@jcaianirh
Copy link
Member Author

/test e2e-aws-console-olm

@jcaianirh jcaianirh closed this Oct 18, 2019
@jcaianirh jcaianirh reopened this Oct 18, 2019
@jcaianirh
Copy link
Member Author

/test e2e-aws-console-olm

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9d7924a into openshift:master Oct 18, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 18, 2019 •
edited
Loading

@jcaianirh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 6b0ca40 link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcaianirh jcaianirh deleted the create-route-test branch October 18, 2019 21:17
@spadgett spadgett added this to the v4.3 milestone Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@jcaianirh @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot