Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scenario file name inconsistency #3001

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Fix scenario file name inconsistency #3001

merged 1 commit into from
Oct 21, 2019

Conversation

rhrazdil
Copy link

Changing
kubevirt-plugin/integration-tests/tests/vm.detail.flavor.ts ➡️ kubevirt-plugin/integration-tests/tests/vm.detail.flavor.scenario.ts

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Oct 17, 2019
@rhrazdil
Copy link
Author

/test e2e-aws-console-olm

@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2019
@rhrazdil rhrazdil force-pushed the console-kubevirt-fix-vmdetail-filename branch from 92040ee to 8135b6f Compare October 21, 2019 07:47
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2019
@rhrazdil rhrazdil force-pushed the console-kubevirt-fix-vmdetail-filename branch from 8135b6f to a99d7b9 Compare October 21, 2019 07:50
@rhrazdil
Copy link
Author

/retest

@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2019
@vojtechszocs
Copy link
Contributor

/lgtm

Thanks @rhrazdil for fixing this.

This change is also in #2051 due to using glob patterns like integration-tests/**/*.scenario.ts instead of manually listing all files. I'll rebase #2051 on top of this.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rhrazdil, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2019
@openshift-merge-robot openshift-merge-robot merged commit b19c79c into openshift:master Oct 21, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@vojtechszocs vojtechszocs

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@rhrazdil @pcbailey @vojtechszocs @openshift-ci-robot @spadgett @openshift-merge-robot