Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to devconsole test suite - updates to be in synch with UI. #3045

Conversation

ldimaggi
Copy link
Contributor

Changes are minor - looks like changes to the UI were not reflected in the tests.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2019
@ldimaggi
Copy link
Contributor Author

Please review - @sanketpathak

@ldimaggi ldimaggi force-pushed the repair-failing-devconsole-suite branch from 4cf289f to 699884c Compare October 22, 2019 14:24
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2019
@ldimaggi ldimaggi force-pushed the repair-failing-devconsole-suite branch from 699884c to 62f824c Compare October 22, 2019 21:58
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2019
@ldimaggi ldimaggi force-pushed the repair-failing-devconsole-suite branch 3 times, most recently from 0221671 to 9f489ea Compare October 24, 2019 14:34
@ldimaggi
Copy link
Contributor Author

/retest

3 similar comments
@christianvogt
Copy link
Contributor

/retest

@ldimaggi
Copy link
Contributor Author

/retest

@ldimaggi
Copy link
Contributor Author

/retest

@ldimaggi ldimaggi force-pushed the repair-failing-devconsole-suite branch from 9f489ea to 89ae1ad Compare October 27, 2019 20:59
@christianvogt
Copy link
Contributor

@ldimaggi lint errors

@ldimaggi ldimaggi force-pushed the repair-failing-devconsole-suite branch 3 times, most recently from 9e17da2 to 7d50206 Compare October 31, 2019 13:57
@ldimaggi
Copy link
Contributor Author

/retest

4 similar comments
@ldimaggi
Copy link
Contributor Author

/retest

@ldimaggi
Copy link
Contributor Author

/retest

@ldimaggi
Copy link
Contributor Author

/retest

@ldimaggi
Copy link
Contributor Author

/retest

@ldimaggi ldimaggi force-pushed the repair-failing-devconsole-suite branch from 7d50206 to 4bf4f66 Compare October 31, 2019 17:04
@ldimaggi
Copy link
Contributor Author

/test e2e-gcp-console

@ldimaggi ldimaggi force-pushed the repair-failing-devconsole-suite branch from 4bf4f66 to 97cc2d2 Compare October 31, 2019 19:38
@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, ldimaggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.3 milestone Nov 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit d62b7bf into openshift:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants