Implement popover for cataog sources with disabled status #3072
Conversation
openshift-ci-robot
added
size/L
TheRealJon
force-pushed
the
catalog-source-list-popover
branch
from
091adde
to
c9c828d
Compare
frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx
Outdated
Show resolved
Hide resolved
TheRealJon
force-pushed
the
catalog-source-list-popover
branch
from
c9c828d
to
65b1cf1
Compare
TheRealJon
force-pushed
the
catalog-source-list-popover
branch
from
65b1cf1
to
dca3969
Compare
|
@TheRealJon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
1 similar comment
|
/retest |
| @@ -8,6 +9,8 @@ const PopoverStatus: React.FC<PopoverStatusProps> = ({ | |||
| icon, | |||
| activeIcon, | |||
| children, | |||
| isVisible = null, | |||
| shouldClose = null, | |||
There was a problem hiding this comment.
Do we need to default to null? I'd think undefined would be OK
There was a problem hiding this comment.
There is a conditional check in the underlying component which will ignore the isVisible prop as long as it === null. I have a feeling that letting it default to undefined might cause some undesired behavior.
There was a problem hiding this comment.
That almost sounds like a bug in the PF component. It treats null and undefined differently?
openshift-ci-robot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-gcp Test has been removed |
|
@spadgett: Overrode contexts on behalf of spadgett: ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind feature |
openshift-ci-robot
added
the
kind/feature
Add popover to 'Disabled' status for catalog sources on the OperatorHub config details page.