Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRD details page #3073

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Update CRD details page #3073

merged 1 commit into from
Oct 24, 2019

Conversation

spadgett
Copy link
Member

https://jira.coreos.com/browse/CONSOLE-1835

  • Show additional properties with popover help
  • Show CRD conditions

/assign @rhamilto

Screen Shot 2019-10-23 at 1 53 43 PM

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@spadgett spadgett mentioned this pull request Oct 23, 2019
Closed
rhamilto
rhamilto approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@spadgett
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2019
@spadgett
Update CRD details page
c04199a 
* Show additional properties with popover help
* Show CRD conditions
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@spadgett
Copy link
Member Author

spadgett commented Oct 23, 2019 •
edited
Loading

I fixed the header positioning and added alt text to the established icon.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2019
rhamilto
rhamilto reviewed Oct 24, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

/retest

@spadgett spadgett added this to the v4.3 milestone Oct 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit f24e42f into openshift:master Oct 24, 2019
@spadgett spadgett deleted the crd-conditions branch October 24, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@spadgett @openshift-ci-robot @rhamilto @openshift-merge-robot