Wait for cluster version resource to load #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
component/core
spadgett
reviewed
Oct 24, 2019
| @@ -167,6 +167,7 @@ const ClusterAlerts = withDashboardResources( | |||
| const alerts = getAlerts(alertsResponse); | |||
|
|
|||
| const cv = _.get(resources.cv, 'data') as ClusterVersionKind; | |||
| const cvLoaded = _.get(resources.cv, 'loaded'); | |||
There was a problem hiding this comment.
We probably want to check the CLUSTER_VERSION flag before watching this resource.
|
@rawagner It looks like the dashboards page is available on native k8s. I suspect a lot of things will fail when not running on OpenShift. |
spadgett
approved these changes
Oct 24, 2019
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawagner, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
known olm flake /retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spadgett this will fix the case when alerts are loaded (and there arent any) and the status card will show
No cluster alerts or messagesand after a while Cluster Version resource is loaded and the card will show available update.