-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused AlertManagersListContainer #3101
Remove unused AlertManagersListContainer #3101
Conversation
Remove `AlertManagersListContainer` and `AlertManagersNameList`, which was only used by `AlertManagersListContainer`. Also stop exporting `AlertManagersList` and `PrometheusInstancesList` since they are not used outside their files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/kind cleanup |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
Remove
AlertManagersListContainer
andAlertManagersNameList
, whichwas only used by
AlertManagersListContainer
.Also stop exporting
AlertManagersList
andPrometheusInstancesList
since they are not used outside their files.
CC @spadgett