Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Status: API Request Success Rate only with 5xx requests #3119

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Cluster Status: API Request Success Rate only with 5xx requests #3119

merged 1 commit into from
Oct 29, 2019

Conversation

metalmatze
Copy link
Contributor

The Cluster Status dashboard has a gauge that shows the API Request Success Rate. However right now it also takes 404 requests into account, which are considered success from an API point of view.
Thus updating the query slightly to only take 5xx as errors.
The updated version is also what we alert on in the cluster monitoring stack.

/cc @openshift/openshift-team-monitoring

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2019
@kyoto
Copy link
Member

kyoto commented Oct 28, 2019

FYI @rawagner, @spadgett

lilic
lilic approved these changes Oct 28, 2019
View reviewed changes
Copy link

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks! lgtm

paulfantom
paulfantom approved these changes Oct 28, 2019
View reviewed changes
Copy link

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@kyoto
Copy link
Member

kyoto commented Oct 28, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@sttts
Copy link

sttts commented Oct 28, 2019

/lgtm

bwplotka
bwplotka approved these changes Oct 28, 2019
View reviewed changes
Copy link

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks 👍

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bwplotka, kyoto, LiliC, metalmatze, paulfantom, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

/retest

1 similar comment
@spadgett
Copy link
Member

/retest

@spadgett spadgett added this to the v4.3 milestone Oct 28, 2019
@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

Test failure is https://jira.coreos.com/browse/CONSOLE-1860

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

level=error msg="Error: Error creating DNS RecordSet: googleapi: Error 503: Backend Error, backendError"

/retest

@metalmatze
Copy link
Contributor Author

/retest

1 similar comment
@paulfantom
Copy link

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 03a27a4 into openshift:master Oct 29, 2019
@openshift-ci-robot
Copy link
Contributor

@metalmatze: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 35af44c link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom paulfantom approved these changes

@lilic lilic lilic approved these changes

@bwplotka bwplotka bwplotka approved these changes

Assignees

@kyoto kyoto

@sttts sttts

@paulfantom paulfantom

@bwplotka bwplotka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
10 participants
@metalmatze @kyoto @sttts @openshift-ci-robot @spadgett @paulfantom @openshift-bot @lilic @bwplotka @openshift-merge-robot