Correct SR-IOV resourceName prefix in network attachment definitions form

[pcbailey]

This PR corrects the prefix for the SR-IOV network type changing it from bridge.network.kubevirt.io to openshift.io. Example YAML output is below:

apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
  annotations:
    k8s.v1.cni.cncf.io/resourceName: openshift.io/sriov_net
  creationTimestamp: '2019-11-03T22:32:40Z'
  generation: 1
  name: test-sriov
  namespace: test-project
  resourceVersion: '3811298'
  selfLink: >-
    /apis/k8s.cni.cncf.io/v1/namespaces/test-project/network-attachment-definitions/test-sriov
  uid: d841499b-fe89-11e9-bf66-525400f2bdf7
spec:
  config: '{"name":"test-sriov","type":"sriov","cniVersion":"0.3.1","ipam":{}}'

@phoracek

[phoracek]

@fedepaol could you please check that the NetworkAttachmentDefinition is valid?

[fedepaol]

/lgtm

One note: the openshift.io prefix depends on the fact that the resource is being set up by the sr-iov operator (but I think this is the case).
Also, in our tests / examples I don't recall setting the cniVersion value.

[openshift-ci-robot]

@fedepaol: changing LGTM is restricted to collaborators

In response to this:

/lgtm

One note: the openshift.io prefix depends on the fact that the resource is being set up by the sr-iov operator (but I think this is the case).
Also, in our tests / examples I don't recall setting the cniVersion value.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[phoracek]

@fedepaol we don't set it there. But we should be explicit about the version, I think it is even required with some newer releases of Multus/kubelet. May be wrong. However, it is specified in SR-IOV operator and it should not do any harm.

https://github.com/openshift/sriov-network-operator/blob/master/bindata/manifests/cni-config/sriov-cni-config.yaml

[rawagner]

/lgtm

[pcbailey]

/retest

[pcbailey]

/retest

[rawagner]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, pcbailey, phoracek, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/network-attachment-definition-plugin/OWNERS [pcbailey,rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pcbailey]

/retest