Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds labels to metadata as well along with template #3232

Merged
merged 1 commit into from
Nov 5, 2019
Merged

adds labels to metadata as well along with template #3232

merged 1 commit into from
Nov 5, 2019

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Nov 5, 2019 •
edited
Loading

adds labels to metadata as well along with the template.

Tracks: https://jira.coreos.com/browse/ODC-2170

  • In topology sidebar overview

Screenshot 2019-11-05 at 3 10 18 PM

  • in search overview

Screenshot 2019-11-05 at 3 08 30 PM

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/knative Related to knative-plugin labels Nov 5, 2019
@invincibleJai
Copy link
Member Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 5, 2019
rohitkrai03
rohitkrai03 approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@gijohn
Copy link
Contributor

gijohn commented Nov 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gijohn, invincibleJai, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gijohn
Copy link
Contributor

gijohn commented Nov 5, 2019

/test e2e-gcp-console

@nemesis09 nemesis09 mentioned this pull request Nov 5, 2019
Merged
@invincibleJai
Copy link
Member Author

/test e2e-gcp-console

2 similar comments
@invincibleJai
Copy link
Member Author

/test e2e-gcp-console

@invincibleJai
Copy link
Member Author

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot merged commit b73e2e5 into openshift:master Nov 5, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@gijohn gijohn Awaiting requested review from gijohn

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

Assignees

@gijohn gijohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@invincibleJai @gijohn @openshift-ci-robot @rohitkrai03 @spadgett @openshift-merge-robot