-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter revisions based on traffic status #3339
filter revisions based on traffic status #3339
Conversation
/cc @openshift/team-devconsole-ux @serenamarie125 |
/test e2e-gcp-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
037411d
to
d76c753
Compare
d76c753
to
2813c49
Compare
@serenamarie125 FYI, service block will be empty as in the description till revisions are ready and receive traffic https://user-images.githubusercontent.com/9278015/68602262-0744a480-04cc-11ea-8fc0-efd459ecb924.png |
@invincibleJai I rebased with you PR locally and this is fixed in your PR #3288. I can no longer see revision outside the service box if they do not have traffic |
/kind bug |
/test e2e-gcp-console |
add uni tests for added utils lint
2813c49
to
e511eb2
Compare
/lgtm |
/test e2e-gcp-console |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ODC-bug: https://jira.coreos.com/browse/ODC-2191
This Pr adds a filter to show only revision with some traffic on them
TODO: