Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter revisions based on traffic status #3339

Merged

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Nov 11, 2019

ODC-bug: https://jira.coreos.com/browse/ODC-2191

This Pr adds a filter to show only revision with some traffic on them

TODO:

  • unit tests

Screenshot from 2019-11-11 21-40-46

Screenshot from 2019-11-11 21-45-45

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2019
@openshift-ci-robot openshift-ci-robot added the component/knative Related to knative-plugin label Nov 11, 2019
@invincibleJai
Copy link
Member

invincibleJai commented Nov 11, 2019

/cc @openshift/team-devconsole-ux @serenamarie125

@rohitkrai03
Copy link
Contributor

/test e2e-gcp-console

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2019
@invincibleJai
Copy link
Member

@sahil143 verified locally works as expected, however currently with just this changes if the revision is not in traffic block it'll appear outside service box. IMO this should be handled as part of #3288

@invincibleJai
Copy link
Member

@serenamarie125 FYI, service block will be empty as in the description till revisions are ready and receive traffic

https://user-images.githubusercontent.com/9278015/68602262-0744a480-04cc-11ea-8fc0-efd459ecb924.png

@sahil143
Copy link
Contributor Author

sahil143 commented Nov 12, 2019

@sahil143 verified locally works as expected, however currently with just this changes if the revision is not in traffic block it'll appear outside service box. IMO this should be handled as part of #3288

@invincibleJai I rebased with you PR locally and this is fixed in your PR #3288. I can no longer see revision outside the service box if they do not have traffic

@invincibleJai
Copy link
Member

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 12, 2019
@invincibleJai
Copy link
Member

/test e2e-gcp-console

add uni tests for added utils

lint
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@invincibleJai
Copy link
Member

/test e2e-gcp-console

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d822da2 into openshift:master Nov 13, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants