Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for knative Service on the Add page #3471

Merged
merged 1 commit into from
Nov 19, 2019
Merged

check for knative Service on the Add page #3471

merged 1 commit into from
Nov 19, 2019

Conversation

debsmita1
Copy link
Contributor

This PR fixes:

  • adds the knative service to the list of resources we fetch in the Add page
  • checks for one resource per kind to decide whether to show the no workloads found banner on the Add page

Issue : https://jira.coreos.com/browse/ODC-2232

GIF:
final_5dd40430ae94cc0014ee9e9c_285527

@debsmita1
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality component/dev-console Related to dev-console labels Nov 19, 2019
@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, debsmita1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6cd6760 into openshift:master Nov 19, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt Awaiting requested review from christianvogt

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@debsmita1 @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot