Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eslint and related packages #3747

Merged
merged 1 commit into from Jan 17, 2020
Merged

Bump eslint and related packages #3747

merged 1 commit into from Jan 17, 2020

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Dec 10, 2019 •
edited

Updating eslint and related packages to work with TS 3.7

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2019
@spadgett spadgett mentioned this pull request Dec 11, 2019
Merged
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2019
@TheRealJon TheRealJon changed the title [WIP] Bump eslint Bump eslint and related packages Dec 12, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2019
@TheRealJon
Copy link
Member Author

@spadgett @benjaminapetersen I think this is ready for review. Sorry for the massive amount of changes. Apparently prettier rules changed which caused a lot of auto-fixes.

@TheRealJon
Copy link
Member Author

@christianvogt I think I have addressed all of your comments. Removing the 'import/order' rule greatly reduced the number of changes.

@TheRealJon
Copy link
Member Author

@spadgett Fixed lint errors. Every time a new PR merges, I have to rebase and fix any lint errors that were introduced.

@spadgett
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
This was referenced Jan 16, 2020
Merged
Merged
Merged
Merged
Merged
Merged
@spadgett
Copy link
Member

/retest

This was referenced Jan 16, 2020
Merged
Merged
@spadgett
Copy link
Member

/test frontend

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@spadgett
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4aa613e into openshift:master Jan 17, 2020
This was referenced Jan 17, 2020
Merged
Merged
@spadgett spadgett added the area/dependency Issues or PRs related to dependency changes label Jan 17, 2020
@spadgett spadgett added kind/dependency-change Categorizes issue or PR as related to changing dependencies and removed area/dependency Issues or PRs related to dependency changes labels Jul 28, 2020
@andrewballantyne andrewballantyne mentioned this pull request Jun 2, 2021
Merged
4 tasks
@TheRealJon TheRealJon deleted the bump-eslint branch January 28, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt christianvogt left review comments

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@benjaminapetersen benjaminapetersen

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@TheRealJon @spadgett @benjaminapetersen @andrewballantyne @christianvogt @openshift-bot @openshift-ci-robot @openshift-merge-robot