Introduce V2V VM Import test case #3975
Conversation
openshift-ci-robot
added
size/L
| await click(applyButton); | ||
| } | ||
|
|
||
| async save() { |
There was a problem hiding this comment.
I am not big fan of these one-liner functions. IIUC, there is no expectation for additional business logic to be added here in the near future. Simple await click(saveButton); makes more sense to me.
Similar comment to other functions.
| await importWizard.next(); | ||
| // Review | ||
| await importWizard.confirmAndCreate(); | ||
| await importWizard.waitForCreation(); |
There was a problem hiding this comment.
Would it make sense to check the result?
This can be added in a follow-up, if complicated now.
There was a problem hiding this comment.
I don't think additional checking errors would be beneficial at the moment.
Currently the function call await importWizard.waitForCreation(); waits for success message, so if the creation fails for some reason, exception will be raised here and we'll have a screenshot taken wit the error.
We could improve it by reading the error message and returning it if VM creation fails, so that we can work with the error in the test function. This could be definitely useful for negative test scenarios.
I would leave it for a separate effort though.
rhrazdil
force-pushed
the
v2v_happy_path
branch
from
5f3538a
to
ce51817
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mareklibra, rhrazdil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Implemented VM import scenario
Created
kubevirt-v2vtest suite in kubevirt-plugin