Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1798884: Add tests to check main dashboard status card against OCS cluster status changes #3812

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Bug 1798884: Add tests to check main dashboard status card against OCS cluster status changes #3812

merged 1 commit into from
Feb 19, 2020

Conversation

shyRozen
Copy link
Contributor

Tests that verify OCP dashboard main page card status health status and icon colors.

@openshift-ci-robot
Copy link
Contributor

Hi @shyRozen. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/ceph Related to ceph-storage-plugin labels Dec 19, 2019
@shyRozen shyRozen changed the title add tests to check main dashboard status card against OCS cluster status changes Add tests to check main dashboard status card against OCS cluster status changes Dec 19, 2019
@shyRozen
Copy link
Contributor Author

/assign @cloudbehl

@shyRozen
Copy link
Contributor Author

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 19, 2019
@shyRozen
Copy link
Contributor Author

/retest

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2019
@shyRozen
Copy link
Contributor Author

/test e2e-gcp-console

@gnehapk
Copy link
Contributor

gnehapk commented Dec 20, 2019

/test e2e-gcp-console

4 similar comments
@shyRozen
Copy link
Contributor Author

/test e2e-gcp-console

@gnehapk
Copy link
Contributor

gnehapk commented Dec 20, 2019

/test e2e-gcp-console

@shyRozen
Copy link
Contributor Author

/test e2e-gcp-console

@shyRozen
Copy link
Contributor Author

/test e2e-gcp-console

@shyRozen
Copy link
Contributor Author

/retest

1 similar comment
@shyRozen
Copy link
Contributor Author

/retest

@shyRozen
Copy link
Contributor Author

@bipuladh @cloudbehl @rhrazdil Please review.

@openshift-ci-robot
Copy link
Contributor

@shyRozen: This pull request references Bugzilla bug 1798884, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1798884: Add tests to check main dashboard status card against OCS cluster status changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 6, 2020
@bipuladh
Copy link
Contributor

bipuladh commented Feb 6, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2020
@shyRozen
Add ocp-dashboard-card-healthcheck.scenario.ts and ocp-dashboard-card…
fe9b344 
…-healthcheck.view.ts to check ocp dashboard status card with ceph cluster changes
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@bipuladh
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, shyRozen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.5 milestone Feb 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1798884, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ff806d4 into openshift:master Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

@shyRozen: All pull requests linked via external trackers have merged. Bugzilla bug 1798884 has been moved to the MODIFIED state.

In response to this:

Bug 1798884: Add tests to check main dashboard status card against OCS cluster status changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebenahar ebenahar ebenahar left review comments

@bipuladh bipuladh bipuladh left review comments

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@rawagner rawagner Awaiting requested review from rawagner

@gnehapk gnehapk Awaiting requested review from gnehapk

Assignees

@cloudbehl cloudbehl

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.
9 participants
@shyRozen @openshift-ci-robot @gnehapk @bipuladh @openshift-bot @spadgett @ebenahar @cloudbehl @openshift-merge-robot