Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Alternative Search to PR3719 #3870

Closed
wants to merge 3 commits into from
Closed

Conversation

zherman0
Copy link
Member

@zherman0 zherman0 commented Jan 6, 2020

This is an alternative solution to PR3719. It uses the PF4 checkbox dropdown. This code is rough and POC level ATM. Although it looks good (minus some css tweaks), the filter bar does not work inside the dropdown as the PF4 component does not send the filter input 'up' to the higher component for us to actually use.
Screenshot_2020-01-06 Search · OKD

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. component/core Related to console core functionality labels Jan 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zherman0
To complete the pull request process, please assign benjaminapetersen
You can assign the PR to them by writing /assign @benjaminapetersen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@zherman0: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/frontend 67b836d link /test frontend
ci/prow/e2e-gcp-console 67b836d link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zherman0
Copy link
Member Author

zherman0 commented Jan 7, 2020

@spadgett @benjaminapetersen - Take a look at this option for search replacement. It does not work with the filter inside the dropdown because the input is not sent up out of the component currently.

@zherman0
Copy link
Member Author

Closing in favor of solution #3875

@zherman0 zherman0 closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants