Change search to handle multiple resources and update search page #3875
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
zherman0
changed the title
|
@spadgett @benjaminapetersen - Our home grown non-PF solution for the search dropdown. This is the third PR for search options. |
zherman0
changed the title
zherman0
force-pushed
the
multi-homemade
branch
from
3361a31
to
9723d79
Compare
openshift-ci-robot
added
size/XL
zherman0
force-pushed
the
multi-homemade
branch
2 times, most recently
from
e4b1dda
to
248c032
Compare
zherman0
force-pushed
the
multi-homemade
branch
from
47dd935
to
881f552
Compare
|
@zherman0 here's my branch with updates I mentioned I worked on yesterday. There's some conflicts with your most recent commit, which I think where addressing the same issue that I did. So I didn't open a pr against yours. gif showing how it looks |
|
There is an open issue with the search page that should be investigated with this work: https://issues.redhat.com/browse/CONSOLE-1981 |
zherman0
force-pushed
the
multi-homemade
branch
from
881f552
to
20dc294
Compare
|
/retest |
zherman0
force-pushed
the
multi-homemade
branch
3 times, most recently
from
f0fcaac
to
2456d0c
Compare
|
/retest |
zherman0
force-pushed
the
multi-homemade
branch
from
2456d0c
to
474346b
Compare
zherman0
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@spadgett @benjaminapetersen - This is ready for review. While this was fairly large, the fact I changed search.jsx to search.tsx makes it a lot to look over. Thanks. |
|
Experientally, I would prefer if it didn't automatically close on every checkbox select. Its a bit cumbersome to select multiple items:
|
@benjaminapetersen - I did discuss this with UX. The thought was that most users would probably want only one item since that is how it works today. If we force a user to close after one click then that greatly affects their experience. Now, if 80% of people do multiple search, then we should definitely leave it open. |
|
/retest |
|
@zherman0 I would think "click outside" would close effectively, rather than require an explicit "close". |
|
It seems to be
I can imagine users wanting to search by label primarily, however.
|
zherman0
force-pushed
the
multi-homemade
branch
from
0aad1c7
to
415d8fb
Compare
|
/retest |
There's no API to search across all resources by label. I'm not sure it's practical to run a separate list for every resource even with a label selector, so we ask the user to pick a resource first. |
|
Yeah thought about that after a bit, there is not |
|
/lgtm I think we are good to go with this one (if CI opens up). Can address any follows as bugs or future Jira if needed. |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Holding on #4065 |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This updates the search page to transition to the new UX desgin. https://openshift.github.io/openshift-origin-design/admin-perspective/future-openshift/search/search
This will be a multi step process spread over version 4.4 and 4.5. This is step 1.
Instead of using patternfly4 select options, it uses an in house dropdown solution that includes a typeahead filter. (This is an alternative solution to PR3719, which is now closed)
Since Events uses the same component, it too as changed. The Events sections are now labelled to identify what is being shown and multiple resources can be selected.
