Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show network metrics on pod page #3901

Merged

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Jan 8, 2020

Screen Shot 2020-01-08 at 4 12 25 PM

/assign @s-urbaniak @kyoto
Can you help with the queries?

@smarterclayton fyi

@spadgett spadgett added this to the v4.4 milestone Jan 8, 2020
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 8, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jan 8, 2020
@spadgett
Copy link
Member Author

spadgett commented Jan 8, 2020

/test analyze

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Jan 9, 2020

/test analyze

Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 207174a into openshift:master Jan 15, 2020
@kyoto
Copy link
Member

kyoto commented Jan 21, 2020

FYI @openshift/openshift-team-monitoring

@brancz
Copy link

brancz commented Jan 21, 2020

Looks good, thanks!

@spadgett spadgett deleted the pod-network-metrics branch January 21, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants