Show VMI details #3949

yaacov · 2020-01-14T12:18:38Z

Show VMI as type of Virtual Machine

Design:
openshift/openshift-origin-design#310

Screenshot:
VM Details page:

VMI Details page:

VM List page:

yaacov · 2020-01-14T12:22:42Z

@irosenzw @glekner @suomiy hi, this is a none-working/moving draft, but any comment/help will be appreciated, keep in mind the code is changing.

yaacov · 2020-01-15T07:08:37Z

/test analyze
/test e2e-gcp-console

yaacov · 2020-01-15T16:02:45Z

/test analyze
/test e2e-gcp-console

atiratree · 2020-01-21T15:47:39Z

frontend/packages/kubevirt-plugin/src/selectors/vm/combined.ts

@@ -44,3 +50,27 @@ export const findConversionPod = (vm: VMKind, pods: PodKind[]) => {
    );
  });
 };
+
+export const findLauncherPod = (vm: VMKind | VMIKind, pods: PodKind[]) => {


I think we already have this function: Please see findVMPod

merged findVMPod and findLauncherPod

atiratree · 2020-01-21T15:49:11Z

frontend/packages/kubevirt-plugin/src/selectors/vm/vmlike.ts

 import { selectVM } from '../vm-template/selectors';

 export const isVM = (vmLikeEntity: VMLikeEntityKind | VMIKind): vmLikeEntity is VMKind =>
  vmLikeEntity && vmLikeEntity.kind === VirtualMachineModel.kind;

+export const isVMI = (vmLikeEntity: VMLikeEntityKind | VMIKind): vmLikeEntity is VMIKind =>


maybe it would make sense to enhance the VMLikeEntityKind with VMIKind. WDYT?

vmi is now a vmilike kind 👍

atiratree · 2020-01-21T16:00:50Z

frontend/packages/kubevirt-plugin/src/components/vm-like/vm-like-resource-link.tsx

+  return (
+    <span className={classes}>
+      <ResourceIcon
+        kind={isVM(obj) ? VirtualMachineModel.kind : VirtualMachineInstanceModel.kind}


you could use getVMLikeModel here if we enhance VMLikeEntityKind

atiratree · 2020-01-21T16:12:48Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-details-page.tsx

+      breadcrumbsFor={breadcrumbsForVMPage(props.match)}
+    />
+  ) : (
+    vmiLoaded && (


we should take into account that the data should not be editable in the VMI like boot order/nics etc.

👍 disabled edit kebabs on nics and discs

atiratree · 2020-01-21T16:22:54Z

frontend/packages/kubevirt-plugin/src/components/vm-like/vm-like-details-page.tsx

+export const VMLikeDetailsPage: React.FC<VirtualMachinesDetailsPageProps> = (props) => {
+  const { name, ns: namespace } = props.match.params;
+  const resources = [
+    getResource(VirtualMachineModel, {


can we rather move this to VirtualMachinesDetailsPage and listen there on what is missing?

atiratree · 2020-01-21T16:26:17Z

frontend/packages/kubevirt-plugin/src/components/vm-like/vm-like-resource-link.tsx

+  const name = getName(obj);
+  const namespace = getNamespace(obj);
+
+  const VMpath = resourcePath(VirtualMachineModel.kind, name, namespace);


shouldn't this kind be conditional as well?

The idea of this component is to always point to the .../virtualmachines/... path.
so if someone press the VMI link we want them to always end up in the .../virtualmachines/... page.

looked at the docs, no need to share paths, yeee :-) , removed the code that share vm and vmi paths 👍

atiratree · 2020-01-21T16:41:40Z

frontend/packages/kubevirt-plugin/src/statuses/vm/vm.ts

@@ -249,6 +256,29 @@ export const getVMStatus = ({
  );
 };

+export const getVMIStatus = ({


IMO we should refactor VM statuses. Nevertheless could we separate VMI status and do it in a followup?

+1 for refactoring, leaving as is for now.

merged the vm and vmi get status methods

atiratree · 2020-01-22T12:33:23Z

frontend/packages/kubevirt-plugin/src/statuses/vm/vm.ts

+    isBeingMigrated(obj, migrations) || //  -||-
+    (vm && isBeingImported(vm, pods)) || //  -||-
+    (vm && isBeingStopped(vm, launcherPod)) ||
+    (vm && isRunning(vm)) ||


can we rename this to isOff? - it is really confusing this way

atiratree · 2020-01-22T12:34:49Z

frontend/packages/kubevirt-plugin/src/statuses/vm/vm.ts

  vmi?: VMIKind;
  pods?: PodKind[];
  migrations?: K8sResourceKind[];
 }): VMStatus => {
-  const launcherPod = findVMPod(vm, pods);
+  const obj = vm || vmi;


can we name it vmLike?

atiratree · 2020-01-22T12:40:08Z

frontend/packages/kubevirt-plugin/src/statuses/vm/vm.ts

-    isWaitingForVMI(vm) || { status: VM_STATUS_UNKNOWN }
+    isVMError(obj) ||
+    isCreated(obj, launcherPod) ||
+    (vm && isWaitingForVMI(vm)) ||


Suggested change

(vm && isWaitingForVMI(vm)) ||

(!vmi && vm && isWaitingForVMI(vm)) ||

atiratree · 2020-01-22T12:40:28Z

frontend/packages/kubevirt-plugin/src/statuses/vm/vm.ts

+    isV2VConversion(obj, pods) || // these statuses must precede isRunning() because they do not rely on ready vms
+    isBeingMigrated(obj, migrations) || //  -||-
+    (vm && isBeingImported(vm, pods)) || //  -||-
+    (vm && isBeingStopped(vm, launcherPod)) ||


IMO isBeingStopped and isCreated (wrong usage now) can be used with just a presence of VMI.

We just need to substitute isVMCreated(vm) with just a presence of VMI and we can check the underlying pods in both these methods

atiratree · 2020-01-22T12:45:55Z

frontend/packages/kubevirt-plugin/src/statuses/vm/vm.ts

@@ -177,7 +183,7 @@ const isBeingImported = (vm: VMKind, pods?: PodKind[]): VMStatus => {
  return NOT_HANDLED;
 };

-const isV2VConversion = (vm: VMKind, pods?: PodKind[]): VMStatus => {
+const isV2VConversion = (vm: VMLikeEntityKind, pods?: PodKind[]): VMStatus => {


IMO we should not overuse this type. We should use it in places which can trully handle all 3 types, which is not this case. Can you please make another type for vm and vmi or change it back to VMKind | VMIKind

atiratree · 2020-01-22T12:50:36Z

frontend/packages/kubevirt-plugin/src/selectors/vmi/basic.ts

@@ -9,6 +9,9 @@ export const getVMIDisks = (vmi: VMIKind): VMIKind['spec']['domain']['devices'][
 export const getVMINetworks = (vmi: VMIKind): VMIKind['spec']['networks'] =>
  vmi && vmi.spec && vmi.spec.networks ? vmi.spec.networks : [];

+export const getVMIVolumes = (vmi: VMIKind): VMIKind['spec']['volumes'] =>
+  vmi && vmi.spec && vmi.spec.voluems ? vmi.spec.volumes : [];


voluems ?

although in the future these selectors could handle VMLikeEntityKind and add spec.template when needed

these selectors would need a second thought - lets not get into this right now

still wrong

atiratree · 2020-01-22T12:52:23Z

frontend/packages/kubevirt-plugin/src/selectors/vmi-migration/combined.ts

 import { getMigrationVMIName, isMigrating } from './selectors';

-export const findVMIMigration = (vmi: VMIKind | VMKind, migrations?: K8sResourceKind[]) => {
+export const findVMIMigration = (vmi: VMLikeEntityKind, migrations?: K8sResourceKind[]) => {


can we keep the old ?

atiratree · 2020-01-22T13:00:16Z

frontend/packages/kubevirt-plugin/src/selectors/vm/selectors.ts

@@ -92,7 +92,7 @@ export const getFlavorDescription = (vm: VMKind) => {
  return resourceStr || undefined;
 };

-export const getVMStatusConditions = (vm: VMKind) =>
+export const getVMStatusConditions = (vm: VMLikeEntityKind) =>


can we refine the types here and in other places?

atiratree · 2020-01-22T13:04:30Z

frontend/packages/kubevirt-plugin/src/selectors/pod/selectors.ts

@@ -46,40 +39,6 @@ export const isPodSchedulable = (pod: PodKind) => {
  );
 };

-export const findVMPod = (


what is wrong with this function? Why can't we keep it ?

switched back :-)

atiratree · 2020-01-22T13:06:56Z

frontend/packages/kubevirt-plugin/src/selectors/event/filters.ts

  kind === VirtualMachineModel.kind && name === getName(vm) && namespace === getNamespace(vm);

-const vmiEventFilter = (vm: VMKind | VMIKind): EventFilterFunction => ({ kind, namespace, name }) =>
+const vmiEventFilter = (vm: VMLikeEntityKind): EventFilterFunction => ({ kind, namespace, name }) =>


lets make another type for VMKind | VMIKind and use these where needed

you can even do

export type VMILikeEntityKind = VMKind | VMIKind; export type VMLikeEntityKind = VMILikeEntityKind | TemplateKind;

there are places where we dont expect VMI. What about?

export type VMILikeEntityKind = VMKind | VMIKind; export type VMLikeEntityKind = VMKind | TemplateKind; export type VMGenericLikeEntityKind = VMLikeEntityKind | VMILikeEntityKind

still not sure about the naming
thoughts?

atiratree · 2020-01-22T13:24:05Z

frontend/packages/kubevirt-plugin/src/selectors/vm/vmlike.ts

@@ -1,17 +1,24 @@
 import { K8sKind } from '@console/internal/module/k8s';


we can keep these functions

atiratree · 2020-01-22T13:31:23Z

frontend/packages/kubevirt-plugin/src/components/vms/vmi-details-page.tsx

+      resources={resources}
+      breadcrumbsFor={breadcrumbsForVMPage(props.match)}
+    >
+      <HintBlock


let's please check the ownerReferences first before we show that

I changes the text to make sense also when this VMI is owned :-)

p.s.
for this PR users should not end up in a VMI details if it's owned because we removed the easy links to it.

I don't know if this is a good solution. Please consider removing it or making it conditional.

Btw they will end up here quite easily when they click on a link in VM events

atiratree · 2020-01-22T13:33:29Z

frontend/packages/kubevirt-plugin/src/components/vms/vmi-details-page.tsx

+
+  const breadcrumbsForVMPage = (match: any) => () => [
+    {
+      name: VirtualMachineModel.labelPlural,


just making sure that this is correct?

yes, the idea is to have the same page ... for vm and vmi, It do have different path now, but user should see the same breadcrumbs for both ...

p.s.
when changing namespace it will get to the wrong list, but this will have to be looked at at later time.

for the detail, shouldn't hurt removing the namespace select altogether

makes sense to me too, this is a console wise change, so not for this PR, I agree we should look how to do this.

atiratree · 2020-01-22T13:34:53Z

frontend/packages/kubevirt-plugin/src/components/vms/vmi-details-page.tsx

+    disksPage,
+  ];
+
+  const resources = [


we should lookup the vm if it has one - for the status.

atiratree · 2020-01-22T13:38:49Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-details.tsx

+
+  const resources = [
+    getResource(ServiceModel, { namespace: getNamespace(vmProp), prop: 'services' }),
+  ];

  return (
    <div className="co-m-pane__body">


we should pass down a flag - what kind of page we are showing as both vm and vmi can be present. The user can easily navigate to VMI even if VM is there

atiratree · 2020-01-22T13:44:31Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

        editButtonId={prefixedID(id, 'cdrom-edit')}
        onEditClick={() => VMCDRomModal({ vmLikeEntity: vm, modalClassName: 'modal-lg' })}
        idValue={prefixedID(id, 'cdrom')}
        isNotAvail={cds.length === 0}
      >
-        <DiskSummary disks={cds} vm={vm} />
+        {vm && <DiskSummary disks={cds} vm={vm} />}


we can show it but it should not be editable

it's not editable

but it should be at least visible

atiratree · 2020-01-22T13:47:23Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

@@ -121,14 +121,6 @@ export const VMDetailsList: React.FC<VMResourceListProps> = ({
        <VMStatuses vm={vm} vmi={vmi} pods={pods} migrations={migrations} />
      </VMDetailsItem>



why are we removing the VMI instance link? I though Pod link should be removed

:-) things change ... the reason is that the vm and vmi page show the same data ... so no new info ...
p.s.
leaving it will require the page to know if it's a vm of vmi page ...

atiratree · 2020-01-22T13:48:28Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

        editButtonId={prefixedID(id, 'cdrom-edit')}
        onEditClick={() => VMCDRomModal({ vmLikeEntity: vm, modalClassName: 'modal-lg' })}
        idValue={prefixedID(id, 'cdrom')}
        isNotAvail={cds.length === 0}
      >
-        <DiskSummary disks={cds} vm={vm} />
+        {vm && <DiskSummary disks={cds} vm={vm} />}
      </VMDetailsItem>

      <VMDetailsItem


lets please forbid editing for flavor and dedicated resources as well

btw, does it make sense to create a <Context> for all components to check if it is a vm or vmi to set editability of their fields? E.g. annotations and description should be editable and others most likely not

It will be nice to know if we are in vm or vmi, but we can do it in a follow up because it will need to be tested and we may introduce new bugs if we do it too quickly.

editing still possible

atiratree · 2020-01-22T14:05:42Z

...end/packages/kubevirt-plugin/src/components/dashboards-page/vm-dashboard/vm-details-card.tsx


-  const ipAddrs = getVmiIpAddressesString(vmi, vmStatus);
+  const ipAddrs = getVmiIpAddresses(vmi).join(', ');


getVmiIpAddressesString can be removed now

atiratree · 2020-01-22T14:37:23Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-details-page.tsx

+      namespace={namespace}
+      kind={VirtualMachineModel.kind}
+      kindObj={VirtualMachineModel}
+      menuActions={menuActionsCreator}


menuActions need to be fixed to take VMI into account + also the Consoles

atiratree · 2020-01-22T16:32:24Z

frontend/packages/kubevirt-plugin/src/statuses/vm/vm.ts

+    isV2VConversion(vmLike, pods) || // these statuses must precede isRunning() because they do not rely on ready vms
+    isBeingMigrated(vmLike, migrations) || //  -||-
+    (vm && isBeingImported(vm, pods)) || //  -||-
+    (vmi && isBeingStopped(vm, launcherPod)) ||


the vmi check should go inside so we check for the status of the launcher pod

atiratree · 2020-01-22T16:33:10Z

frontend/packages/kubevirt-plugin/src/statuses/vm/vm.ts

-    isCreated(vm, launcherPod) ||
-    isWaitingForVMI(vm) || { status: VM_STATUS_UNKNOWN }
+    isVMError(vmLike) ||
+    (vmi && isCreated(vmLike, launcherPod)) ||


atiratree · 2020-01-22T16:35:13Z

frontend/packages/kubevirt-plugin/src/selectors/vmi/basic.ts

@@ -9,6 +9,9 @@ export const getVMIDisks = (vmi: VMIKind): VMIKind['spec']['domain']['devices'][
 export const getVMINetworks = (vmi: VMIKind): VMIKind['spec']['networks'] =>
  vmi && vmi.spec && vmi.spec.networks ? vmi.spec.networks : [];

+export const getVMIVolumes = (vmi: VMIKind): VMIKind['spec']['volumes'] =>
+  vmi && vmi.spec && vmi.spec.voluems ? vmi.spec.volumes : [];


still wrong

atiratree · 2020-01-22T16:38:18Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/combined-disk.ts

-      disks: getDisks(vm),
-      volumes: getVolumes(vm),
+      disks: vmi && vmi.spec ? getVMIDisks(vmi) : getDisks(vm),
+      volumes: vmi && vmi.spec ? getVMIVolumes(vmi) : getVolumes(vm),


why do we have to check for the spec?

atiratree · 2020-01-22T16:41:59Z

frontend/packages/kubevirt-plugin/src/components/vms/vmi-details-page.tsx

+      resources={resources}
+      breadcrumbsFor={breadcrumbsForVMPage(props.match)}
+    >
+      <HintBlock


I don't know if this is a good solution. Please consider removing it or making it conditional.

Btw they will end up here quite easily when they click on a link in VM events

atiratree · 2020-01-22T16:42:11Z

frontend/packages/kubevirt-plugin/src/components/vms/vmi-details-page.tsx

+
+  const breadcrumbsForVMPage = (match: any) => () => [
+    {
+      name: VirtualMachineModel.labelPlural,


atiratree · 2020-01-22T16:45:01Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

@@ -121,14 +121,6 @@ export const VMDetailsList: React.FC<VMResourceListProps> = ({
        <VMStatuses vm={vm} vmi={vmi} pods={pods} migrations={migrations} />
      </VMDetailsItem>



atiratree · 2020-01-22T16:46:16Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

        editButtonId={prefixedID(id, 'cdrom-edit')}
        onEditClick={() => VMCDRomModal({ vmLikeEntity: vm, modalClassName: 'modal-lg' })}
        idValue={prefixedID(id, 'cdrom')}
        isNotAvail={cds.length === 0}
      >
-        <DiskSummary disks={cds} vm={vm} />
+        {vm && <DiskSummary disks={cds} vm={vm} />}
      </VMDetailsItem>

      <VMDetailsItem


editing still possible

atiratree · 2020-01-22T16:46:44Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

        editButtonId={prefixedID(id, 'cdrom-edit')}
        onEditClick={() => VMCDRomModal({ vmLikeEntity: vm, modalClassName: 'modal-lg' })}
        idValue={prefixedID(id, 'cdrom')}
        isNotAvail={cds.length === 0}
      >
-        <DiskSummary disks={cds} vm={vm} />
+        {vm && <DiskSummary disks={cds} vm={vm} />}


but it should be at least visible

atiratree · 2020-01-22T16:48:45Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

-  const devices = getDevices(vm);
+  const launcherPod = findVMPod(vmLike, pods);
+  const id = getBasicID(vmLike);
+  const cds = vm ? getCDRoms(vm) : [];


should work for vmi as well

working and visible :-)

atiratree · 2020-01-22T17:04:37Z

frontend/packages/kubevirt-plugin/src/components/vms/vmi-details-page.tsx

+  );
+};
+
+export type VirtualMachinesDetailsPageProps = {


please change the name as it is a duplicate

atiratree · 2020-01-22T17:04:46Z

frontend/packages/kubevirt-plugin/src/components/vms/vmi-details-page.tsx

+
+import './vmi-details-page.scss';
+
+export const VirtualMachinesInstanseDetailsPage: React.FC<VirtualMachinesDetailsPageProps> = (


thanks 👍

yaacov · 2020-01-23T08:26:36Z

@suomiy hi, conflict was with #3985
I checked and unpause looks like still working

yaacov · 2020-01-23T08:38:54Z

/test analyze

- move around imports to prevent circular dependencies - better naming? - add flavor/workload/os to the vmi when creating the vms - show all VMI details correctly and without editing possibilities (except description) - fix types - do not load unnecesary resources in vm console - fix description editing when empty - do not show empty template link in VMI - unify selectors for VMWrapper and VMIWrapper

jelkosz · 2020-01-23T21:31:35Z

/lgtm

openshift-ci-robot · 2020-01-23T21:32:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jelkosz, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [jelkosz,yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-24T00:03:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-24T05:16:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-01-24T05:26:47Z

@yaacov: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	`7e1c078`	link	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot requested review from jelkosz and rhrazdil January 14, 2020 12:19

yaacov force-pushed the kubevirt-vmi-details-in-vm-page branch 4 times, most recently from 09d0362 to b521dba Compare January 15, 2020 05:06

This was referenced Jan 15, 2020

Remove pod link from vm overview #3924

Closed

Surfacing VMIs in the UI openshift/openshift-origin-design#310

Merged

yaacov force-pushed the kubevirt-vmi-details-in-vm-page branch from b521dba to 99a0bb4 Compare January 15, 2020 15:23

yaacov force-pushed the kubevirt-vmi-details-in-vm-page branch from 99a0bb4 to 2332126 Compare January 21, 2020 09:18

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2020

yaacov force-pushed the kubevirt-vmi-details-in-vm-page branch 2 times, most recently from 2194862 to 205472c Compare January 21, 2020 13:20

atiratree suggested changes Jan 21, 2020

View reviewed changes

yaacov force-pushed the kubevirt-vmi-details-in-vm-page branch from 205472c to f38743f Compare January 21, 2020 17:00

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2020

yaacov force-pushed the kubevirt-vmi-details-in-vm-page branch from f38743f to 952547b Compare January 21, 2020 17:15

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2020

yaacov changed the title ~~[WIP] Show VMI details~~ Show VMI details Jan 21, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2020

yaacov force-pushed the kubevirt-vmi-details-in-vm-page branch 2 times, most recently from 63ede6f to 5d8d8d2 Compare January 21, 2020 22:02

atiratree suggested changes Jan 22, 2020

View reviewed changes

atiratree reviewed Jan 22, 2020

View reviewed changes

atiratree suggested changes Jan 22, 2020

View reviewed changes

yaacov force-pushed the kubevirt-vmi-details-in-vm-page branch from 0cc4846 to cb94102 Compare January 22, 2020 14:57

atiratree suggested changes Jan 22, 2020

View reviewed changes

atiratree reviewed Jan 22, 2020

View reviewed changes

yaacov force-pushed the kubevirt-vmi-details-in-vm-page branch 2 times, most recently from a546fcc to 6bb1d80 Compare January 23, 2020 08:08

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2020

yaacov added 3 commits January 23, 2020 22:00

expose VMI details page

41b972f

rebase take 1

d2a8dbd

rebase take 11

7e900f1

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020

atiratree force-pushed the kubevirt-vmi-details-in-vm-page branch from 9582e13 to 7e1c078 Compare January 23, 2020 21:22

openshift-ci-robot assigned jelkosz Jan 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020

openshift-merge-robot merged commit 0711f4b into openshift:master Jan 24, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

atiratree mentioned this pull request Jan 29, 2020

Show only the allowed storage interfaces on Disk-modal #4028

Merged

yaacov mentioned this pull request Feb 4, 2020

Bug 1797974: fix overview status #4171

Merged

	(vm && isWaitingForVMI(vm)) \|\|
	(!vmi && vm && isWaitingForVMI(vm)) \|\|

		@@ -1,17 +1,24 @@
		import { K8sKind } from '@console/internal/module/k8s';

		@@ -121,14 +121,6 @@ export const VMDetailsList: React.FC<VMResourceListProps> = ({
		<VMStatuses vm={vm} vmi={vmi} pods={pods} migrations={migrations} />
		</VMDetailsItem>


		const ipAddrs = getVmiIpAddressesString(vmi, vmStatus);
		const ipAddrs = getVmiIpAddresses(vmi).join(', ');


		import './vmi-details-page.scss';

		export const VirtualMachinesInstanseDetailsPage: React.FC<VirtualMachinesDetailsPageProps> = (

Show VMI details #3949

Show VMI details #3949

Conversation

yaacov commented Jan 14, 2020 • edited

yaacov commented Jan 14, 2020

yaacov commented Jan 15, 2020

yaacov commented Jan 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree Jan 21, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree Jan 22, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree Jan 22, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yaacov commented Jan 14, 2020 •

edited

atiratree Jan 21, 2020 •

edited

atiratree Jan 22, 2020 •

edited

atiratree Jan 22, 2020 •

edited