Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unpause VM feature #3985

Merged
merged 1 commit into from Jan 22, 2020
Merged

Add unpause VM feature #3985

merged 1 commit into from Jan 22, 2020

Conversation

pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Jan 16, 2020 •
edited

This PR adds the option to unpause a paused VM from the overview tab, list view, and actions menu.

List view:
Selection_635

Overview tab:
Selection_634

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2020
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 16, 2020
@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Jan 16, 2020
@pcbailey pcbailey force-pushed the add-unpause-vm-feature branch 2 times, most recently from 2161e61 to 328cd50 Compare January 21, 2020 14:09
@pcbailey pcbailey changed the title WIP: Add unpause VM feature Add unpause VM feature Jan 21, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2020
rawagner
rawagner suggested changes Jan 21, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/src/components/modals/vm-status-modal/vm-status-modal.tsx Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/src/components/modals/vm-status-modal/vm-status-modal.tsx Outdated
const VMStatusModalComponent = ({
vmi,
isOpen,
setOpen,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to pass close which doesnt take any parameters. Same as I mentioned in Gilad's PR #3805 (comment) - he is going to do that in a follow up so this should be done too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'll do this in a follow-up, as well.

frontend/packages/kubevirt-plugin/src/components/vm-status/vm-status.tsx Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/src/components/vm-status/vm-status.tsx Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/src/components/vms/menu-actions.tsx Outdated Show resolved Hide resolved
atiratree
atiratree suggested changes Jan 21, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/src/components/modals/vm-status-modal/vm-status-modal.tsx Outdated

const footer = (
<ModalFooter
errorMessage={showPatchError && errorMessage}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need showPatchError. Can't we just show errorMessage directly?

frontend/packages/kubevirt-plugin/src/k8s/requests/vmi/actions.ts Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/src/components/vms/menu-actions.tsx Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/src/k8s/requests/vmi/actions.ts Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/src/k8s/requests/vmi/actions.ts
url = `${url}/${action}`;

const response = await coFetch(url, { method });
const text = await response.text();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just return the text - please update the VMActionRequest as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also parametrize this method by the model, but I am not sure we want to do that

frontend/packages/kubevirt-plugin/src/components/vm-status/vm-status.tsx Outdated
@@ -102,6 +115,11 @@ export const VMStatus: React.FC<VMStatusProps> = ({
)}`; // to default tab
const additionalText = verbose ? getAdditionalImportText(statusDetail.pod) : null;

const unpauseVMI = async (event) => {
event.preventDefault();
await unpauseVM(vmi);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we do something here when this fails?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the error should be handled in some way. Lets do it as a follow up @pcbailey

frontend/packages/kubevirt-plugin/src/statuses/vm/vm.ts
@@ -237,6 +242,7 @@ export const getVMStatus = ({
}): VMStatus => {
const launcherPod = findVMPod(vm, pods);
return (
isPaused(vmi) ||
Copy link
Member

@atiratree atiratree Jan 21, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO importing should be first

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's keep the priority for that one

@atiratree
Copy link
Member

atiratree commented Jan 21, 2020 •
edited

Shouldn't we also include pause action to complement the unpause one?

I see now, that we do not want to expose this feature

@pcbailey pcbailey force-pushed the add-unpause-vm-feature branch 2 times, most recently from d32edd2 to 4d9691d Compare January 21, 2020 15:59
@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/hold
the merge queue is blocked

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020
@spadgett
Copy link
Member

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@jelkosz
Copy link

jelkosz commented Jan 22, 2020

/retest

@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@pcbailey
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3b2b2b1 into openshift:master Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

@pcbailey: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 2c3f1e6 link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yaacov yaacov mentioned this pull request Jan 23, 2020
Merged
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
This was referenced Jan 29, 2020
Closed
Merged
@pcbailey pcbailey deleted the add-unpause-vm-feature branch October 26, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner requested changes

@atiratree atiratree atiratree requested changes

@mareklibra mareklibra mareklibra left review comments

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@pcbailey @atiratree @rawagner @openshift-bot @spadgett @jelkosz @openshift-ci-robot @mareklibra @openshift-merge-robot